fix: enable stdin on exec. fixes kata containers output#231
Open
XT-Phate wants to merge 1 commit intoactions:mainfrom
Open
fix: enable stdin on exec. fixes kata containers output#231XT-Phate wants to merge 1 commit intoactions:mainfrom
XT-Phate wants to merge 1 commit intoactions:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Enable stdin forwarding in execPodStep calls to address truncated output when running against Kata containers.
- Pass
process.stdintoexecPodStepin the Alpine check helper. - Include
process.stdinin therunScriptStephook invocation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/k8s/src/k8s/index.ts | Pass process.stdin into execPodStep for the Alpine check |
| packages/k8s/src/hooks/run-script-step.ts | Forward process.stdin when invoking execPodStep in runScriptStep |
Comments suppressed due to low confidence (3)
packages/k8s/src/k8s/index.ts:529
- This change enables passing stdin to execPodStep for Kata containers; consider adding or updating tests to verify that stdin is forwarded correctly in both standard and Kata container environments.
process.stdin
packages/k8s/src/hooks/run-script-step.ts:30
- Consider adding or updating tests for runScriptStep to ensure that passing process.stdin to execPodStep correctly handles interactive input scenarios, especially with Kata containers.
process.stdin
packages/k8s/src/hooks/run-script-step.ts:30
- [nitpick] Since multiple callers now explicitly pass process.stdin, consider making process.stdin the default value for the stdin parameter in execPodStep, removing the need for callers to pass it each time.
process.stdin
Signed-off-by: Maxime Bertin <mbertin@luccasoftware.com>
5984503 to
1edda12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When running the github hook against
katacontainers, the script output cannot be fetched properly from kata. Only a bit of the stdout/stderr are properly forwarded to GHWorkaround this issue from kata
Resolution
Enabling stdin solves that issue and should not impact other workloads