fix(HubPoolClient): Handle disabled pool rebalance routes #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

fusmanii merged 18 commits into master from faisal/acx-4264-sdk-make-sure-hubpoolclient-is-able-to-process-disabling

Aug 14, 2025

Contributor

fusmanii commented Aug 7, 2025 •

edited

Loading

Updated getL2TokenForL1TokenAtBlock, getL1TokenForL2TokenAtBlock, and getL1TokenForDeposit to not throw and instead return Address | undefined
Updated l1TokensToDestinationTokensWithBlock to also include mappings to zero address
Deleting l1TokensToDestinationTokens entry when a zero address mapping is detected

linear bot commented Aug 7, 2025

ACX-4264 [sdk] Make sure HubPoolClient is able to process disabling PoolRebalanceRoute gracefully

fusmanii commented

View reviewed changes

package.json Show resolved Hide resolved

fusmanii marked this pull request as ready for review

August 7, 2025 19:40

fusmanii requested review from pxrl, bmzig, grasphoper, dijanin-brat and nicholaspai

August 7, 2025 19:41

grasphoper approved these changes

View reviewed changes

nicholaspai approved these changes

View reviewed changes

bmzig reviewed

View reviewed changes

src/clients/HubPoolClient.ts Outdated Show resolved Hide resolved

bmzig approved these changes

View reviewed changes

pxrl reviewed

View reviewed changes

src/clients/HubPoolClient.ts Outdated Show resolved Hide resolved

pxrl reviewed

View reviewed changes

src/clients/HubPoolClient.ts Outdated Show resolved Hide resolved

fusmanii commented

View reviewed changes

src/clients/HubPoolClient.ts Outdated Show resolved Hide resolved

pxrl reviewed

View reviewed changes

src/clients/HubPoolClient.ts Outdated Show resolved Hide resolved

fusmanii added the do not merge label

fusmanii force-pushed the faisal/acx-4264-sdk-make-sure-hubpoolclient-is-able-to-process-disabling branch from 6a4eb0e to f6ce97f Compare

August 11, 2025 17:19

grasphoper self-requested a review

August 11, 2025 23:55

fusmanii commented

View reviewed changes

src/clients/HubPoolClient.ts Outdated Show resolved Hide resolved

fusmanii requested review from bmzig, nicholaspai and pxrl

August 12, 2025 00:27

grasphoper reviewed

View reviewed changes

src/clients/BundleDataClient/utils/FillUtils.ts Outdated Show resolved Hide resolved

src/clients/HubPoolClient.ts Outdated Show resolved Hide resolved

src/clients/HubPoolClient.ts Outdated Show resolved Hide resolved

src/clients/HubPoolClient.ts Outdated Show resolved Hide resolved

grasphoper self-requested a review

August 12, 2025 15:53

fusmanii removed the do not merge label

bmzig reviewed

View reviewed changes

src/clients/BundleDataClient/utils/PoolRebalanceUtils.ts Outdated Show resolved Hide resolved

bmzig reviewed

View reviewed changes

src/clients/BundleDataClient/utils/DataworkerUtils.ts Outdated Show resolved Hide resolved

bmzig reviewed

View reviewed changes

src/clients/BundleDataClient/utils/DataworkerUtils.ts Outdated Show resolved Hide resolved


          fix(HubPoolClient): Handle pool rebalance disabling

67bfa66

fusmanii added 14 commits

August 13, 2025 13:45


          Removed logs

b570741


          Fixed typo

dcd345d


          Added optimization by filtering by block number first

5c4bf33


          Delete entry from l2TokenEnabledForL1Token

f57217c


          Refactored hubpollclien to account for disbaling rebalance routes

05ace30


          fix: updated usage to fib failing build

388393d


          fix: tests

d903b62


          lint

52ba602


          Added tests for disabling a rebalance route

7445bc1


          test

b1c94b7


          Removed l1TokensToDestinationTokens var

fef6246


          Sorting rebalance route events on insertion

2c9a6ff


          Added asserts for getL1TokenForL2TokenAtBlock calls

f667104


          lint

7f7c062

fusmanii force-pushed the faisal/acx-4264-sdk-make-sure-hubpoolclient-is-able-to-process-disabling branch from 184c79c to 7f7c062 Compare

August 13, 2025 17:45

fusmanii added 2 commits

August 13, 2025 14:31


          Added asserts for l1token calls

37e60eb


          Bump sdk version

a68a78a

bmzig approved these changes

View reviewed changes

Contributor

bmzig left a comment

Very nice.


          Updated test

1150e4c

grasphoper approved these changes

View reviewed changes

fusmanii merged commit 4af064d into master

4 checks passed

pxrl added a commit that referenced this pull request


          chore: Temporarily revert "Handle disabled pool rebalance routes (#1182…

b798aa0

…)"

This reverts commit 4af064d.

The commit is backed out as a precaution to permit SDK to be bumped in
the relayer without having to worry about this throwing up issues.
Probability is low, but we'll bump when Faisal is available to monitor.

grasphoper mentioned this pull request

feat(HubPoolClient): Handle disabled pool rebalance routes #1198

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet