[WIP] improve(SpokePoolClient): Validate raw event types #1157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxrl
commented
Jul 28, 2025
| @@ -5,7 +5,7 @@ import { BigNumber } from "../utils"; | |||
|
|
|||
| const AddressValidator = define<string>("AddressValidator", (v) => ethersUtils.isAddress(String(v))); | |||
| const HexValidator = define<string>("HexValidator", (v) => ethersUtils.isHexString(String(v))); | |||
| const BigNumberValidator = define<BigNumber>("BigNumberValidator", (v) => BigNumber.isBigNumber(v)); | |||
| export const BigNumberValidator = define<BigNumber>("BigNumberValidator", (v) => BigNumber.isBigNumber(v)); | |||
|
|
|||
| const V3DepositSchema = object({ | |||
There was a problem hiding this comment.
todo: Refactor to share some definitions with V3DepositSchema. It's unfortunately not composable because it defines all possible fields, but it has the advantage of being more granular in its validation. I would propose to refactor such that it is defined as a product of smaller, composable types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial WIP to demonstrate a possible way forward.