chore: Use Address.toNative() in HubPoolClient #1156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where the HubPoolClient is handling mainnet tokens, use Address.toNative(). Also some additional driveby fixes and tweaks.
pxrl
commented
Jul 25, 2025
src/clients/HubPoolClient.ts
Outdated
Comment on lines
414
to
418
| // Filter hubPoolTokens for duplicates by reverting to their native string | ||
| // representation. This is required for deduplication to work reliably. | ||
| const getHubPoolTokens = (): EvmAddress[] => dedupArray( | ||
| Object.values(hubPoolTokens).filter(isDefined).map((token) => token.toNative()) | ||
| ).map(EvmAddress.from); |
There was a problem hiding this comment.
Driveby fix - it's not recommended to use dedupArray() on complex types, so translate the addresses to strings before deduplicating.
nicholaspai
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where the HubPoolClient is handling mainnet tokens, use Address.toNative().
Also some additional driveby fixes and tweaks.