Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch description for custom object to longer type #320

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

kuzmany
Copy link

@kuzmany kuzmany commented May 26, 2023

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

Longer descriptions like 191 characters return errors. Increase description length.

Steps to test this PR:

  1. Open this PR for testing locally (see docs on testing PRs here)
  2. Run mautic:plugins:reload
  3. Create a custom object with description longer like 191 chars.
  4. After PR should work

@acquia-stalebot-platauto
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@acquia-stalebot-platauto
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the stale label to avoid it being closed. Thank you for your contributions. More info: https://github.com/acquia/devops-github-administration/blob/main/docs/operations_related_to_repositories.md#acquia-stale-bot

@escopecz escopecz removed the stale label Mar 17, 2025
@PierreAmmeloot
Copy link

@escopecz who can we contact for a review?

@escopecz
Copy link
Contributor

@PierreAmmeloot can you make the review and test this?

@PierreAmmeloot
Copy link

@escopecz Yes, it should be possible, but how do you go about it?

@escopecz
Copy link
Contributor

I'm not sure what skills you have so It's hard to recommend the best way, but I'd install Mautic with DDEV and then install this plugin into it. The staging branch works on Mautic 4, the 5.x branch on Mautic 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants