Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import custom objects on background #318

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from

Conversation

kuzmany
Copy link

@kuzmany kuzmany commented May 19, 2023

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

If you import on background import failed with errors:

You do not have permission to create Items for Custom Object 3

The PR avoid check permission during import on background.

Steps to test this PR:

  1. Open this PR for testing locally (see docs on testing PRs here)
  2. Create import on background
  3. Run bin/console mautic:import
  4. See If import run correctly after PR

Verified

This commit was signed with the committer’s verified signature.
stanislav-tkach Stanislav Tkach
@escopecz
Copy link
Contributor

I don't think this is the right fix for this. And I don't know why it works for us and not for you. But I think the proper fix would be to set the user in the ImportCommand because we know who scheduled the import job. So we'd just set that user to the UserHelper. This way users won't be able to go around the permission.

kuzmany added 2 commits May 26, 2023 08:03

Verified

This commit was signed with the committer’s verified signature.
stanislav-tkach Stanislav Tkach
This reverts commit 7277c1f.

Verified

This commit was signed with the committer’s verified signature.
stanislav-tkach Stanislav Tkach
@kuzmany
Copy link
Author

kuzmany commented May 26, 2023

@escopecz I rewrite check permission for import creator on background processing.

kuzmany added 2 commits May 26, 2023 08:07

Verified

This commit was signed with the committer’s verified signature.
stanislav-tkach Stanislav Tkach

Verified

This commit was signed with the committer’s verified signature.
stanislav-tkach Stanislav Tkach
@acquia-stalebot-platauto
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@acquia-stalebot-platauto
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please remove the stale label to avoid it being closed. Thank you for your contributions. More info: https://github.com/acquia/devops-github-administration/blob/main/docs/operations_related_to_repositories.md#acquia-stale-bot

@escopecz escopecz removed the stale label Mar 17, 2025
@PierreAmmeloot
Copy link

@escopecz what can be done to help this subject move forward?

@escopecz
Copy link
Contributor

The conflict must be resolved, the PR must be reviewed and tested.

@PierreAmmeloot
Copy link

I can help if you tell me how. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants