Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACMS-4504: Remove Acquia CMS Common Dependency from Drupal Starter Kit Headless module. #1930

Merged
merged 17 commits into from
Mar 6, 2025
Merged

ACMS-4504: Remove Acquia CMS Common Dependency from Drupal Starter Kit Headless module. #1930

merged 17 commits into from
Mar 6, 2025

Conversation

rajeshreeputra
Copy link
Contributor

Motivation
Fixes #ACMS-4504

Proposed changes

  • Remove Acquia CMS Common Dependency from Drupal Starter Kit Headless module.
  • Add Entity clone module test dependency.
  • Update test accordingly.

Alternatives considered
NA

Testing steps
Follow from ticket.

Merge requirements

  • Major change, Minor change, Bug, Enhancement, and/or Chore label applied
  • Manual testing by a reviewer

@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment February 28, 2025 09:09 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment February 28, 2025 09:11 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment February 28, 2025 10:38 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment March 3, 2025 08:10 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment March 3, 2025 08:13 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment March 3, 2025 08:31 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment March 3, 2025 08:54 — with GitHub Actions Inactive
@deepakmishra2
Copy link
Contributor

I see there are lot of unnecessary changes which should not be part of this ticket, our main purpose should be strictly removing acquia_cms_common dependency from headless.
cc @vishalkhode1

@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment March 3, 2025 12:05 — with GitHub Actions Inactive
rajeshreeputra
rajeshreeputra commented Mar 3, 2025
View reviewed changes
Copy link
Contributor Author

@rajeshreeputra rajeshreeputra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following my discussion with @vishalkhode1, we will be implementing these changes in the current PR.

I see there are lot of unnecessary changes which should not be part of this ticket, our main purpose should be strictly removing acquia_cms_common dependency from headless.

@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment March 3, 2025 12:56 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment March 3, 2025 13:46 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment March 4, 2025 05:34 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment March 4, 2025 07:49 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment March 5, 2025 04:22 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment March 5, 2025 06:36 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment March 5, 2025 06:41 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment March 5, 2025 06:47 — with GitHub Actions Inactive
@rajeshreeputra rajeshreeputra marked this pull request as ready for review March 5, 2025 07:10
chandan-singh7929
chandan-singh7929 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@chandan-singh7929 chandan-singh7929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rajeshreeputra rajeshreeputra temporarily deployed to acquia_code_deployment March 6, 2025 06:18 — with GitHub Actions Inactive
@vishalkhode1 vishalkhode1 merged commit d8ee4a3 into develop Mar 6, 2025
36 of 42 checks passed
@vishalkhode1 vishalkhode1 deleted the ACMS-4504 branch March 6, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepakmishra2 deepakmishra2 deepakmishra2 left review comments

@chandan-singh7929 chandan-singh7929 chandan-singh7929 approved these changes

@vishalkhode1 vishalkhode1 vishalkhode1 approved these changes

@apathak18 apathak18 Awaiting requested review from apathak18

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajeshreeputra @deepakmishra2 @chandan-singh7929 @vishalkhode1