feat: Added analytics logging on non-admin pages access#229
feat: Added analytics logging on non-admin pages access#229DedsecKnight wants to merge 8 commits intodevelopfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@DedsecKnight i think we should disable analytics while in development? |
|
Good point! Will make that change once I got everything sorted out for this feature. |
|
wait then why is this pr not a draft? |
There was a problem hiding this comment.
I'm concerned that unconditionally placing the analytics calls in useEffect hooks will not provide the correct behavior for analytics. As noted by the docs, useEffect without dependencies runs after every re-render, so it might cause spurious event logs. Instead, we might look into listening to Next.js router events for logging, as detailed in this Next.js + Firebase analytics tutorial. This tutorial show how to use the built-in screen-view tracking feature of Firebase analytics (as opposed to logging custom events for each page).
|
@DedsecKnight does this require an extra env variable? |
Spaceface16518
left a comment
Spaceface16518
left a comment
There was a problem hiding this comment.
Can you remove all the imports you added when you had analytics in each individual page?
@thetechie7 I am not sure what extra env variable you are referring to in this case. |
4 participants
No description provided.