Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ #15

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Add FAQ #15

merged 4 commits into from
Dec 10, 2024

Conversation

alexzhang1618
Copy link
Contributor

Info

Closes #3

Screen.Recording.2024-12-09.at.10.31.13.PM.mov

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
diamondhacks-teaser ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 4:00pm

Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to consider:

  • Is it good UX to only allow one accordion to be open at a time? It's a very common design pattern, but personally I think it's hard to quickly cross reference things that way
  • You could use <details>, which has the benefit that the browser will automatically open it when you ctrl F for something on the page. Maybe search engines will index it too . But it's harder to animate or control

src/components/FAQAccordion/index.tsx Outdated Show resolved Hide resolved
src/sections/FAQ/index.tsx Show resolved Hide resolved
src/sections/FAQ/questions.tsx Outdated Show resolved Hide resolved
src/components/FAQAccordion/index.tsx Outdated Show resolved Hide resolved
@SheepTester
Copy link
Member

Screenshot_20241209-231005
It looks like this on Android Chrome

Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@alexzhang1618 alexzhang1618 merged commit edec7ae into main Dec 10, 2024
4 checks passed
@alexzhang1618 alexzhang1618 deleted the alex/faq branch December 10, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HomePage - FAQ
2 participants