finished inputs #8
Conversation
|
Thanks for contributing! |
There was a problem hiding this comment.
trying it out, it looks good
I think we should allow passing through more HTML props on <input> (see below), plus a few nitpicks
When it shows a hint, I can't click on the text itself to edit it. Maybe pointer-events: none it?
Though that said, on mobile there's currently no way to accept the hint. Maybe tapping on the hint should accept it, while tapping anywhere else goes through to the input. Apparently a child element can override a parent's pointer-events: none so maybe this isn't too difficult to do
|
There was a problem hiding this comment.
dropdown looks too tall
maybe missing box-sizing: border-box?
| } | ||
|
|
||
| return ( | ||
| <div className={`dropdown-wrapper ${theme} ${size}`}> |
There was a problem hiding this comment.
we should probably also have a <select> element so that you can tab focus on it, mostly for accessibility, but on keyboard you can also type the first few letters to select an option
pull request for inputs, making dropdowns in a separate branch