added radio and checkbox #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing! |
|
SheepTester
reviewed
May 27, 2025
| } | ||
|
|
||
| .storybook-checkbox input[type="checkbox"] { | ||
| cursor: pointer; |
There was a problem hiding this comment.
checkbox shouldn't have cursor: pointer when disabled
| checked?: boolean; | ||
| disabled?: boolean; | ||
| mode?: 'light' | 'dark'; | ||
| label?: string; |
There was a problem hiding this comment.
should this be ReactNode? that way you can add formatting to the labels. it should also be required i think since you already wrap the checkbox in a <label>
| import './checkbox.css'; | ||
|
|
||
| export interface CheckboxProps { | ||
| checked?: boolean; |
There was a problem hiding this comment.
should we also add defaultChecked
| import React, { FC, useEffect, useState } from 'react'; | ||
| import './checkbox.css'; | ||
|
|
||
| export interface CheckboxProps { |
There was a problem hiding this comment.
we should also let you specify name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.