Skip to content

Conversation

sidvasu
Copy link
Collaborator

@sidvasu sidvasu commented Jun 29, 2025

No description provided.

@TheJolman
Copy link
Collaborator

I recommend creating a BoardServicer interface like in the other services. This just makes it so the handler doesn't depend on a concrete type.

type BoardServicer interface {
    Service[/* associated params */]
}

@TheJolman
Copy link
Collaborator

Could you rebase or merge off main again? A pr that resolves the singular nouns issue was just merged

@TheJolman
Copy link
Collaborator

hey @sidvasu I modified this pr so that it compiles and correctly implements the BoardServicer interface. A current blocker is that these Servicer interfaces implement the Service interface defined in /internal/api/services/service.go which only defines the basic CRUD operations. As you know the board queries have a lot more than basic CRUD operations attached to them. I just commented a lot of stuff out to get it to compile, but we need to think about how to tackle this at some point.

@TheJolman TheJolman added the api Relating to the API only label Oct 2, 2025
@TheJolman
Copy link
Collaborator

closes #47

@TheJolman
Copy link
Collaborator

Hey @sidvasu I resolved the issues we were having with this, I ended up just not using the Service interface and creating a custom interface for board. Not sure if everything works correclty but everything in SQL code now has a service and handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relating to the API only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants