-
Notifications
You must be signed in to change notification settings - Fork 5
Board service #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Board service #71
Conversation
I recommend creating a BoardServicer interface like in the other services. This just makes it so the handler doesn't depend on a concrete type.
|
Could you rebase or merge off main again? A pr that resolves the singular nouns issue was just merged |
2c64fb6
to
73e1fc1
Compare
hey @sidvasu I modified this pr so that it compiles and correctly implements the BoardServicer interface. A current blocker is that these Servicer interfaces implement the |
closes #47 |
73e1fc1
to
0e405f9
Compare
Hey @sidvasu I resolved the issues we were having with this, I ended up just not using the Service interface and creating a custom interface for board. Not sure if everything works correclty but everything in SQL code now has a service and handler. |
No description provided.