-
Notifications
You must be signed in to change notification settings - Fork 0
Our Principles Section #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
i ran npm run format the second time (not the first), so i think that's why it says there's 2 commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Lydia, it looks good, but this isn't exactly what we're looking for. Could you style using TailwindCSS instead of importing the rectangle and also using HTML to write the text rather than importing the text as an image. You don't have to import any images for this issue.
Some notes that could be handy in your issue:
Use font-pse-maitree for your text font in the grid
Use font-pse-crimson-text for the heading text
I made a PR for the color you should use for the boxes. It should be pse-purple-100. Once this is merged in, pull from the dev branch (git pull origin dev) and use that color.
Check on the the tailwindcss website for syntax on how to make a box and style it.
my comments
|
OKAY i fixed the merge conflict with page.tsx and with my local branch, deleted the svgs in the initial commit and replaced them with tailwindcss styling, swapped the fonts and the colors with the correct one after running git pull origin dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
did i do the file layout correct / put the component in the correct spot by chance