-
Notifications
You must be signed in to change notification settings - Fork 0
PSE Landing Page Banner #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
I guess I messed up and created a branch from my Example component branch, so scrap those commits when this is merged. |
|
Last commit to this fixed pretty much everything. Forgot to mention in the commit that I also changed the h1 tag to a p tag. Changed image types as well. Should be good to merge now. |
src/components/landing/PSEBanner.tsx
Outdated
| <Image | ||
| src={PSEBg} | ||
| alt="PSE Background" | ||
| className="center absolute inset-0 -top-[20px] -z-10 flex w-full scale-120 object-cover" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the banner should be positioned closer to the top of the page. remember to leave room for the navbar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the point of "remember to leave room for the navbar", are the components not called within a flex-col? wouldn't they be dynamically positioned on top of one another? i'll remove the vertical centering for sure, but shouldn't it be fine for it to just go to the top of the page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wait this works fine, I forgot it's absolutely positioned but relative to the div it's inside
src/components/landing/PSEBanner.tsx
Outdated
| const PSEBanner = () => { | ||
| return ( | ||
| <div | ||
| className={`relative flex h-[459px] w-full flex-col items-center justify-center overflow-clip`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see if you can make the height relative to screen size for responsiveness but where it'll look about the same as this pixel size
src/components/landing/PSEBanner.tsx
Outdated
| <p className="font-pse-crimson-text z-10 text-center text-[125px] text-white"> | ||
| Pi Sigma Epsilon | ||
| </p> | ||
| `` | ||
| <p className="font-pse-gfs-didot z-10 -mt-8 text-center text-[40px] text-white"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
responsify text size (with breakpoints)
… fixed scaling, minor fixes
2d2fe08 to
48c881c
Compare
Update Images to Webp
Update Images to Webp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Zayden, it looks really good! I was waiting for the button to be made. Can you import the button and call it within your component. Refer to the figma on spacing/design. Just copy the properties listed in page.tsx.
src/app/page.tsx
Outdated
|
|
||
| const Home = () => { | ||
| return ( | ||
| <div className="flex h-screen w-screen items-center justify-center"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <div className="flex h-screen w-screen items-center justify-center"> | |
| <div className="h-screen w-screen items-center justify-center"> |
| "use client"; | ||
|
|
||
| import Principles from "@/components/landing/Principles"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you deleted principles. Add this component back to page.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, import and add the ourmission component
| text="JOIN US!" | ||
| color="bg-pse-yellow-100" | ||
| />*/} | ||
| <Principles /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call the principles component
src/components/landing/PSEBanner.tsx
Outdated
| <p className="font-pse-maitree z-10 -mt-18 scale-50 text-center text-[40px] whitespace-nowrap text-white transition-transform duration-300 ease-out sm:-mt-16 sm:scale-60 md:-mt-10 md:scale-75 lg:-mt-6 lg:scale-100"> | ||
| University of California, Riverside Chapter | ||
| </p> | ||
| <div className="relative z-10 mt-0 scale-80 transition-transform duration-300 ease-out hover:bg-red-500 sm:mt-2 sm:scale-90 md:mt-8 md:scale-100 lg:mt-10 lg:scale-110"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <div className="relative z-10 mt-0 scale-80 transition-transform duration-300 ease-out hover:bg-red-500 sm:mt-2 sm:scale-90 md:mt-8 md:scale-100 lg:mt-10 lg:scale-110"> | |
| <div className="relative z-10 mt-0 scale-80 transition-transform duration-300 ease-out sm:mt-2 sm:scale-90 md:mt-8 md:scale-100 lg:mt-10 lg:scale-110"> |
| <p className="font-pse-crimson-text scale-50 text-center text-[125px] whitespace-nowrap text-white transition-transform duration-300 ease-out sm:scale-60 md:scale-75 lg:scale-100"> | ||
| Pi Sigma Epsilon | ||
| </p> | ||
| <p className="font-pse-maitree z-10 -mt-18 scale-50 text-center text-[40px] whitespace-nowrap text-white transition-transform duration-300 ease-out sm:-mt-16 sm:scale-60 md:-mt-10 md:scale-75 lg:-mt-6 lg:scale-100"> | ||
| University of California, Riverside Chapter | ||
| </p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try using the text sizes available already. Try to match as best as you can! For example: text-2xl.
| <p className="font-pse-crimson-text scale-50 text-center text-[125px] whitespace-nowrap text-white transition-transform duration-300 ease-out sm:scale-60 md:scale-75 lg:scale-100"> | |
| Pi Sigma Epsilon | |
| </p> | |
| <p className="font-pse-maitree z-10 -mt-18 scale-50 text-center text-[40px] whitespace-nowrap text-white transition-transform duration-300 ease-out sm:-mt-16 sm:scale-60 md:-mt-10 md:scale-75 lg:-mt-6 lg:scale-100"> | |
| University of California, Riverside Chapter | |
| </p> | |
| <p className="font-pse-crimson-text scale-50 text-center text- whitespace-nowrap text-white transition-transform duration-300 ease-out sm:scale-60 md:scale-75 lg:scale-100"> | |
| Pi Sigma Epsilon | |
| </p> | |
| <p className="font-pse-maitree z-10 -mt-18 scale-50 text-center text- whitespace-nowrap text-white transition-transform duration-300 ease-out sm:-mt-16 sm:scale-60 md:-mt-10 md:scale-75 lg:-mt-6 lg:scale-100"> | |
| University of California, Riverside Chapter | |
| </p> |
- I had to add a small margin around the "OurMission" component since it currently has no margin. - I didn't change the text from px to a predefined tailwindcss size because they are all too small and I would have to redo my scaling, which isn't just one simple thing as I have mobile responsiveness in my component (I know you said to leave this, but I already did the work and can just make slight edits later on according to specification instead of a total redo). - The hover:bg-red-500 thing was a remnant from me trying to add something to the button where it gets slightly darker on hover - couldn't get it to work, that was part of me testing to see if I could (I couldn't). meant to remove it. my bad!
| const PSEBanner = () => { | ||
| return ( | ||
| <div | ||
| className={`relative flex h-[309px] w-full flex-col items-center justify-center overflow-clip transition-transform duration-300 ease-out sm:h-[359px] md:h-[409px] lg:h-[459px]`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breakpoints work for the size they're applied at and up. for example, if you want to set a default size for smaller screens and then have medium and larger screens have a larger height for the element, it would look like this:
| className={`relative flex h-[309px] w-full flex-col items-center justify-center overflow-clip transition-transform duration-300 ease-out sm:h-[359px] md:h-[409px] lg:h-[459px]`} | |
| className={`relative flex h-1/5 w-full flex-col items-center justify-center overflow-clip transition-transform duration-300 ease-out md:h-1/2`} |


Fixes #11
Needs a fix to properly scale background. It should be slightly more zoomed in, I just wanted to push this tonight.
The directory for the asset used in the background may need to be changed.
The positioning of elements may be slighty off but I tried to follow the figma.