Skip to content

Conversation

@ZaydenGit
Copy link
Collaborator

@ZaydenGit ZaydenGit commented Oct 12, 2025

image

Fixes #11
Needs a fix to properly scale background. It should be slightly more zoomed in, I just wanted to push this tonight.
The directory for the asset used in the background may need to be changed.
The positioning of elements may be slighty off but I tried to follow the figma.

@ZaydenGit ZaydenGit self-assigned this Oct 12, 2025
@ZaydenGit ZaydenGit added help wanted Extra attention is needed Landing Page labels Oct 12, 2025
@ZaydenGit
Copy link
Collaborator Author

I guess I messed up and created a branch from my Example component branch, so scrap those commits when this is merged.

@ZaydenGit
Copy link
Collaborator Author

Last commit to this fixed pretty much everything. Forgot to mention in the commit that I also changed the h1 tag to a p tag. Changed image types as well. Should be good to merge now.

@ZaydenGit ZaydenGit added Ready for Review and removed help wanted Extra attention is needed labels Oct 14, 2025
<Image
src={PSEBg}
alt="PSE Background"
className="center absolute inset-0 -top-[20px] -z-10 flex w-full scale-120 object-cover"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the banner should be positioned closer to the top of the page. remember to leave room for the navbar

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the point of "remember to leave room for the navbar", are the components not called within a flex-col? wouldn't they be dynamically positioned on top of one another? i'll remove the vertical centering for sure, but shouldn't it be fine for it to just go to the top of the page?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait this works fine, I forgot it's absolutely positioned but relative to the div it's inside

const PSEBanner = () => {
return (
<div
className={`relative flex h-[459px] w-full flex-col items-center justify-center overflow-clip`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see if you can make the height relative to screen size for responsiveness but where it'll look about the same as this pixel size

Comment on lines 16 to 20
<p className="font-pse-crimson-text z-10 text-center text-[125px] text-white">
Pi Sigma Epsilon
</p>
``
<p className="font-pse-gfs-didot z-10 -mt-8 text-center text-[40px] text-white">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

responsify text size (with breakpoints)

@ZaydenGit ZaydenGit force-pushed the ZaydenGit/pi-sigma-epsilon branch from 2d2fe08 to 48c881c Compare October 16, 2025 02:08
@ZaydenGit
Copy link
Collaborator Author

Added breakpoints to properly scale each element for sm, md, and lg displays.
image

Copy link
Collaborator

@brandontran1220 brandontran1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Zayden, it looks really good! I was waiting for the button to be made. Can you import the button and call it within your component. Refer to the figma on spacing/design. Just copy the properties listed in page.tsx.

src/app/page.tsx Outdated

const Home = () => {
return (
<div className="flex h-screen w-screen items-center justify-center">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div className="flex h-screen w-screen items-center justify-center">
<div className="h-screen w-screen items-center justify-center">

@ZaydenGit
Copy link
Collaborator Author

image

Comment on lines 1 to 3
"use client";

import Principles from "@/components/landing/Principles";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you deleted principles. Add this component back to page.tsx

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, import and add the ourmission component

text="JOIN US!"
color="bg-pse-yellow-100"
/>*/}
<Principles />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call the principles component

<p className="font-pse-maitree z-10 -mt-18 scale-50 text-center text-[40px] whitespace-nowrap text-white transition-transform duration-300 ease-out sm:-mt-16 sm:scale-60 md:-mt-10 md:scale-75 lg:-mt-6 lg:scale-100">
University of California, Riverside Chapter
</p>
<div className="relative z-10 mt-0 scale-80 transition-transform duration-300 ease-out hover:bg-red-500 sm:mt-2 sm:scale-90 md:mt-8 md:scale-100 lg:mt-10 lg:scale-110">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div className="relative z-10 mt-0 scale-80 transition-transform duration-300 ease-out hover:bg-red-500 sm:mt-2 sm:scale-90 md:mt-8 md:scale-100 lg:mt-10 lg:scale-110">
<div className="relative z-10 mt-0 scale-80 transition-transform duration-300 ease-out sm:mt-2 sm:scale-90 md:mt-8 md:scale-100 lg:mt-10 lg:scale-110">

Comment on lines +17 to +22
<p className="font-pse-crimson-text scale-50 text-center text-[125px] whitespace-nowrap text-white transition-transform duration-300 ease-out sm:scale-60 md:scale-75 lg:scale-100">
Pi Sigma Epsilon
</p>
<p className="font-pse-maitree z-10 -mt-18 scale-50 text-center text-[40px] whitespace-nowrap text-white transition-transform duration-300 ease-out sm:-mt-16 sm:scale-60 md:-mt-10 md:scale-75 lg:-mt-6 lg:scale-100">
University of California, Riverside Chapter
</p>
Copy link
Collaborator

@brandontran1220 brandontran1220 Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try using the text sizes available already. Try to match as best as you can! For example: text-2xl.

Suggested change
<p className="font-pse-crimson-text scale-50 text-center text-[125px] whitespace-nowrap text-white transition-transform duration-300 ease-out sm:scale-60 md:scale-75 lg:scale-100">
Pi Sigma Epsilon
</p>
<p className="font-pse-maitree z-10 -mt-18 scale-50 text-center text-[40px] whitespace-nowrap text-white transition-transform duration-300 ease-out sm:-mt-16 sm:scale-60 md:-mt-10 md:scale-75 lg:-mt-6 lg:scale-100">
University of California, Riverside Chapter
</p>
<p className="font-pse-crimson-text scale-50 text-center text- whitespace-nowrap text-white transition-transform duration-300 ease-out sm:scale-60 md:scale-75 lg:scale-100">
Pi Sigma Epsilon
</p>
<p className="font-pse-maitree z-10 -mt-18 scale-50 text-center text- whitespace-nowrap text-white transition-transform duration-300 ease-out sm:-mt-16 sm:scale-60 md:-mt-10 md:scale-75 lg:-mt-6 lg:scale-100">
University of California, Riverside Chapter
</p>

- I had to add a small margin around the "OurMission" component since it currently has no margin.
- I didn't change the text from px to a predefined tailwindcss size because they are all too small and I would have to redo my scaling, which isn't just one simple thing as I have mobile responsiveness in my component (I know you said to leave this, but I already did the work and can just make slight edits later on according to specification instead of a total redo).
- The hover:bg-red-500 thing was a remnant from me trying to add something to the button where it gets slightly darker on hover - couldn't get it to work, that was part of me testing to see if I could (I couldn't). meant to remove it. my bad!
const PSEBanner = () => {
return (
<div
className={`relative flex h-[309px] w-full flex-col items-center justify-center overflow-clip transition-transform duration-300 ease-out sm:h-[359px] md:h-[409px] lg:h-[459px]`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breakpoints work for the size they're applied at and up. for example, if you want to set a default size for smaller screens and then have medium and larger screens have a larger height for the element, it would look like this:

Suggested change
className={`relative flex h-[309px] w-full flex-col items-center justify-center overflow-clip transition-transform duration-300 ease-out sm:h-[359px] md:h-[409px] lg:h-[459px]`}
className={`relative flex h-1/5 w-full flex-col items-center justify-center overflow-clip transition-transform duration-300 ease-out md:h-1/2`}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PI SIGMA EPSILON

3 participants