Adjusted naming of files uploaded to Zenodo.#1636
Merged
Merged
Conversation
It seems the library was finding out about the name for the file by calling a mathod on the file handle, and ignoring the separate name string we provided to it. This change makes sure the tmp files have exactly the names we want; they're put in a temp folder named after the deposit ID.
Contributor
|
I think this workaround should help. Should I test? |
MontrealSergiy
approved these changes
Jun 17, 2026
Member
Author
|
@MontrealSergiy Thanks for testing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems the library was finding out about the name for the file by calling a mathod on the file handle, and ignoring the separate name string we provided to it. This change makes sure the tmp files have exactly the names we want; they're put in a temp folder named after the deposit ID. Fixes #1635