Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

laser_warning_system - Add laser warning system API and system for ground vehicles #10770

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

TheCandianVendingMachine
Copy link
Contributor

@TheCandianVendingMachine TheCandianVendingMachine commented Mar 2, 2025

When merged this pull request will:

  • Add API to detect laser hits against units with LWS
  • Add a LWS to all vanilla vehicles
  • Audio callouts
  • GUI object which will allow configuration and setting changes

59 of these files are binary blobs, 9 are rvmats, 6 are configs. sorry about the scary files changed number

Demo 1: https://youtu.be/liCMDDHcF0k?si=IahhpN_vr8G-TtWL

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@TheCandianVendingMachine TheCandianVendingMachine added this to the Ongoing milestone Mar 2, 2025
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick things i saw


{
_y params ["", "", "_laserMethod"];
if (_method isEqualType {} && { _method isNotEqualTo EFUNC(laser,findLaserSource) }) exitWith {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (_method isEqualType {} && { _method isNotEqualTo EFUNC(laser,findLaserSource) }) exitWith {};
if (_laserMethod isEqualType {} && { _laserMethod isNotEqualTo EFUNC(laser,findLaserSource) }) exitWith {};

{
_y params ["", "", "_laserMethod"];
if (_method isEqualType {} && { _method isNotEqualTo EFUNC(laser,findLaserSource) }) exitWith {};
if (_method isEqualType "" && { _method != QEFUNC(laser,findLaserSource) }) exitWith {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (_method isEqualType "" && { _method != QEFUNC(laser,findLaserSource) }) exitWith {};
if (_laserMethod isEqualType "" && { _laserMethod != QEFUNC(laser,findLaserSource) }) exitWith {};

*/
params ["_args", "_pfhId"];

private _state = _object getVariable [QGVAR(state_box), false call FUNC(default_boxState)];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_object undefined, prob from _args?
_display also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants