Merge pull request #4 from michoelchaikin/master

Add support for object member assignment return pattern to entry-points rules
acdvs · Dec 24, 2020 · 380e1e3 · 380e1e3
2 parents be2b5c9 + aa20cd7
commit 380e1e3
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 0 deletions.
diff --git a/lib/rules/entry-points.js b/lib/rules/entry-points.js
@@ -61,6 +61,18 @@ module.exports = {
           }
         }
 
+        if (returnArgument && returnArgument.type === 'Identifier') {
+          const returnAssignments = callbackBody.filter(n =>
+            n.type === 'ExpressionStatement' &&
+            n.expression.left.type === 'MemberExpression' &&
+            n.expression.left.object.name === returnArgument.name &&
+            scriptTypeMap[scriptType].entryPoints.includes(n.expression.left.property.name)
+          );
+          if (returnAssignments.length > 0) {
+            hasValidEntryPoint = true;
+          }
+        }
+
         if (!hasValidEntryPoint) {
           context.report({
             node: returnStatement || callback,

diff --git a/tests/rules/entry-points.js b/tests/rules/entry-points.js
@@ -81,6 +81,18 @@ ruleTester.run('entry-points', rule, {
         '  return { somethingElse: x };',
         '});'
       ].join('\n')
+    },
+    {
+      code: [
+        '/**',
+        ' * @NScriptType ClientScript',
+        ' */',
+        'define([], function() {',
+        '  var exports = {};',
+        '  exports.pageInit = x;',
+        '  return exports;',
+        '});'
+      ].join('\n')
     }
   ],
 
@@ -137,6 +149,33 @@ ruleTester.run('entry-points', rule, {
         '});'
       ].join('\n'),
       errors: [{ messageId: 'returnEntryPoint', data: { type: 'Restlet' }}]
+    },
+    {
+      code: [
+        '/**',
+        ' * @NScriptType ClientScript',
+        ' */',
+        'define([], function() {',
+        '  var exports = {};',
+        '  exports.notAnEntryPoint = x;',
+        '  return exports;',
+        '});'
+      ].join('\n'),
+      errors: [{ messageId: 'returnEntryPoint', data: { type: 'ClientScript' }}]
+    },
+    {
+      code: [
+        '/**',
+        ' * @NScriptType ClientScript',
+        ' */',
+        'define([], function() {',
+        '  var exports = {};',
+        '  var notTheReturnObject = {};',
+        '  notTheReturnObject.pageInit = x;',
+        '  return exports;',
+        '});'
+      ].join('\n'),
+      errors: [{ messageId: 'returnEntryPoint', data: { type: 'ClientScript' }}]
     }
   ]
 });