Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrossPlatform Scrolling updated #70

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Atul-khadse
Copy link

Closes #

Changes

  • Added CSS rule for .CrossPlatform .column.last to resolve layout issue.

Flags

  • This change only involves adding the following CSS rule to resolve the issue:

.CrossPlatform .column.last {
max-height: 800px;
overflow-y: auto;
}

  • No changes have been made to any other parts of the codebase.

Screenshots or Video

Screenshot 2025-01-23 223021

after update

Uploading Screenshot 2025-01-23 223248.png…

Related Issues

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for concerto-docs ready!

Name Link
🔨 Latest commit 9b784e8
🔍 Latest deploy log https://app.netlify.com/sites/concerto-docs/deploys/6793942facb9e8000865b10e
😎 Deploy Preview https://deploy-preview-70--concerto-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sanketshevkar
Copy link
Member

Hi @Atul-khadse
Can you please describe the issue in a bit more detail or add link to an exisiting issue describing it in detail? I'm not really able to make difference between this PR build and the actual build.

@sanketshevkar
Copy link
Member

Okay got it! So the vertical scroll was disabled and now you've enabled it. Can you please confirm if that's the only change in this PR.

Can also please complete dco sign off for your commits. Steps for fixing it are in the deatils for DCO fail check in the PR build checks

@Atul-khadse Atul-khadse reopened this Jan 24, 2025
Signed-off-by: Atul_khadse <[email protected]>
Signed-off-by: Atul_khadse <[email protected]>
@Atul-khadse
Copy link
Author

hello @sanketshevkar
what is wrong this here in PR please guide

@sanketshevkar
Copy link
Member

You might want to link the issue you created here in the description, next to Closes#

#69

@sanketshevkar
Copy link
Member

Everything else LGTM!
Thanks for you contributions! @DianaLease can you please review this PR once again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants