NVDA 2026.1 compatibility and remove legacy compatibility#64
Draft
AAClause wants to merge 5 commits into
Draft
Conversation
Member
AAClause
commented
Feb 17, 2026
AAClause
commented
- Replace controlTypes.ROLE_* and STATE_* constants with Role.* and State.* enums
- Use .displayString property instead of roleLabels/stateLabels dict lookups
- Remove six library usage (iteritems, text_type, string_types, moves.queue)
- Replace deprecated imp module with types.ModuleType
- Update hasCustomModule() to use find_spec for Python 3.12+ compatibility
- Remove try/except blocks for NVDA < 2018.3 and < 2021.1 compatibility
- Fix REASON_CARET compatibility wrapper (no longer needed)
AAClause
force-pushed
the
NVDA-2026.1
branch
from
512afd3 to
d747345
Compare
- Replace controlTypes.ROLE_* and STATE_* constants with Role.* and State.* enums - Use .displayString property instead of roleLabels/stateLabels dict lookups - Remove six library usage (iteritems, text_type, string_types, moves.queue) - Replace deprecated imp module with types.ModuleType - Update hasCustomModule() to use find_spec for Python 3.12+ compatibility - Remove try/except blocks for NVDA < 2018.3 and < 2021.1 compatibility - Fix REASON_CARET compatibility wrapper (no longer needed)
- Use NVDAHelper.localLib.VBuf_getTextInRange with fallback for older versions - Replace nvdaControls.TabbableScrolledPanel with wx.lib.scrolledpanel.ScrolledPanel fallback
- Remove NVDA version checks (buildVersion / NVDA_VERSION < "2023.2") - Remove dead code for NVDA 2014.4 (searchTag_2014, nextTag, previousTag, searchTag wrapper) - Remove Python version_info < 9 guards, use collections.abc directly - Remove unnecessary try/except imports (json, VBuf_getTextInRange) - Remove hasattr guard for addon.isDisabled (available since NVDA 2016.3) - Clean up unused imports (sys, virtualBuffers, NVDAHelper, buildVersion)
AAClause
force-pushed
the
NVDA-2026.1
branch
from
d747345 to
baaa9d0
Compare
…AObject fallback NVDA 2024.3 (commit 9afb6fc5b) changed Gecko IA2 iframe object resolution, so NVDAObjectAtStart can be None for some iframe-related nodes and URL-based zone matching may fail. Add a safe fallback in NodeField.getNVDAObject() using controlIdentifier + getNVDAObjectFromEvent, and harden NodeField.url against missing objects to keep submodule loading behavior retrocompatible.
Use a localLib-first import for VBuf_getTextInRange (NVDA 2026.1+) with a legacy fallback to NVDAHelper.VBuf_getTextInRange (NVDA <= 2025.x). This removes the deprecation warning triggered by NVDAHelper module attribute probing while preserving backward compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.