Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml 1.1 octal parsing behavior #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

firstdorsal
Copy link

See #17

@acatton
Copy link
Owner

acatton commented Feb 10, 2025

Thank you for this pull request. There is a test and everything.

I'm just concerned about breaking things for people using this create, especially since we want to support 1.2 in the future (see #5 )

Let me sleep over this and think how to fix that. At the top of my head, I'm thinking about merging your pull request, but guard it behind a flag, like no1.2compatibilty or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants