Fix get_advisory_url to handle string file paths #2102
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function now accepts both Path objects and strings for the `file` and `base_path` parameters, converting strings to Path objects before calling relative_to(). This fixes the AttributeError that occurred when importers passed string paths instead of Path objects. Fixes: aboutcode-org#2016 Signed-off-by: Mrityunjay Raj <[email protected]>
mr-raj12
force-pushed
the
fix-istio-importer-path
branch
from
f68153c to
1608222
Compare
Collaborator
|
@mr-raj12, could you please add a simple test for the |
- Test string inputs (the bug fix scenario) - Test Path object inputs (original working case) - Test mixed Path/string inputs Addresses reviewer feedback Signed-off-by: Mrityunjay Raj <[email protected]>
Author
|
@ziadhany Test added for The test covers:
All tests pass locally. The PR is ready for review. |
Author
|
@ziadhany Test has been added as requested. All test suites pass successfully. Note: The documentation build is failing due to a broken link in Could you please advise if I should:
Let me know if you'd like me to fix the documentation link as part of this PR. |
Collaborator
|
@mr-raj12 Ignore the CI docs for now, just run the Istio importer locally again and print the logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
get_advisory_url()inutils.pyto accept bothPathobjects and stringsPathobjects before calling.relative_to()AttributeError: 'str' object has no attribute 'relative_to'errorIssue
Fixes :
Changes
from pathlib import Pathimportisinstance()to convert strings to Path objectsTesting
Signed-off-by: Mrityunjay Raj [email protected]