Refine D2D with Grammar (.g/.g4) Class Mapping #1808 #1942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chin Yeung Li <[email protected]>
TG1999
reviewed
Oct 29, 2025
| def find_grammar_packages(self): | ||
| """Find the java package of the .g/.g4 source files.""" | ||
| d2d.find_jvm_packages( | ||
| project=self.project, jvm_lang=jvm.GrammarLanguage, logger=self.log |
There was a problem hiding this comment.
Is GrammarLanguage a JVM based language?
There was a problem hiding this comment.
Not exactly, but it follows the same basename mapping logic in the Java case.
To make its purpose clearer, perhaps we could rename it to find_grammar_java_packages()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support mapping
.classto their corresponding grammar definitions (.g / .g4) files.Note that grammar files are not exclusive to Java; they can also be used for Python, C++, PHP, and other languages.
This PR focuses solely on
.classmapping.Further enhancements can be made over time.