Add dependencies to rpm #4084
Open
Add dependencies to rpm #4084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alok1304
force-pushed
the
649-add-dependencies-to-rpm
branch
from
f9c5a17 to
7b69733
Compare
|
@pombredanne please review this PR, also all test cases have been successfully executed and passed. |
alok1304
force-pushed
the
649-add-dependencies-to-rpm
branch
from
1c0e2b1 to
9bb48db
Compare
Added dependencies to rpm. Reference: aboutcode-org#649 Signed-off-by: Alok Kumar <[email protected]> Signed-off-by: Alok Kumar <[email protected]>
alok1304
force-pushed
the
649-add-dependencies-to-rpm
branch
from
9bb48db to
e16372a
Compare
pombredanne
requested changes
Jan 10, 2025
There was a problem hiding this comment.
Thanks for this effort. Please see comments for feedback:
- This code cannot and does not work as it is: .rpm archives and installed RPM dbs are not the same.
- There is a lot of code duplication
- A package cannot be its own dependency
- Please start by crafting proper tests first so you can set expectations with carefully reviewed cases.
| ) | ||
|
|
||
| # Prepare the dependent package model | ||
| dependencies.append( |
There was a problem hiding this comment.
Since when there is a single dependency?
There was a problem hiding this comment.
@pombredanne Can you suggest how I proceed to find multiple dependencies, I tried by Adding RPMTAG_REQUIRES and RPMTAG_REQUIREVERSION in RPMtags in pyrpm.py but in RPMTAG_REQUIRES I got this like eg: ['/bin/sh', '/bin/sh', '/bin/sh', '/bin/sh', '/bin/sh', 'rpmlib(PayloadFilesHavePrefix)', 'rpmlib(CompressedFileNames)', 'rpmlib(PayloadIsBzip2)']
corresponding I got require_version=[None, None, None, None, None, '4.0-1', '3.0.4-1', '3.0.5-1']
source: http://ftp.rpm.org/max-rpm/ch-queryformat-tags.html (For rpm tages)
can you tell how I proceed to find out their package name and their version, in rmp_requires, these represent capabilities or libraries, not actual packages
There was a problem hiding this comment.
Since when there is a single dependency?
I do for single dependency only.
There was a problem hiding this comment.
I do for single dependency only.
This cannot work. We need all of them.
- You can use "get_rpm_tags" only for a .rpm file, but then you do not need to call it because this is already called
- for installed RPM databases, you can use exclusively the data in
parse_rpm_xmlishhttps://github.com/aboutcode-org/scancode-toolkit/pull/4084/files#diff-17fc898047e57c63a40599213e50fb03f8d853b60ea7790133ace1c6ab2b9709R170 and if it does not return what you need,parse_rpm_xmlishneeds to be updated in https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/packagedcode/rpm_installed.py. Look at require*, provide* and conflict* for instance in https://github.com/aboutcode-org/scancode-toolkit/edit/develop/tests/packagedcode/data/rpm_installed/distro-xmlish/rhel-rpms.xmlish
pombredanne
requested changes
Jan 13, 2025
There was a problem hiding this comment.
@alok1304 you cannot use get_rpm_tags for installed packages. And its dope not make sense to collect "self" as a dependency and to further consider that there is only one dependency which is the package itself.
See also my comments inline
| ) | ||
|
|
||
| # Prepare the dependent package model | ||
| dependencies.append( |
There was a problem hiding this comment.
I do for single dependency only.
This cannot work. We need all of them.
- You can use "get_rpm_tags" only for a .rpm file, but then you do not need to call it because this is already called
- for installed RPM databases, you can use exclusively the data in
parse_rpm_xmlishhttps://github.com/aboutcode-org/scancode-toolkit/pull/4084/files#diff-17fc898047e57c63a40599213e50fb03f8d853b60ea7790133ace1c6ab2b9709R170 and if it does not return what you need,parse_rpm_xmlishneeds to be updated in https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/packagedcode/rpm_installed.py. Look at require*, provide* and conflict* for instance in https://github.com/aboutcode-org/scancode-toolkit/edit/develop/tests/packagedcode/data/rpm_installed/distro-xmlish/rhel-rpms.xmlish
Yes, I got it. I will sure see this and get some idea of this. |
|
@pombredanne I checked .rpm(rpm_archive) for dependencies, there are four things in dependencies.
what I do, I add this in RPMTAGS in pyrmp.py is this right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dependencies to rpm.
Reference: #649
Fixes #649
Tasks
Run tests locally to check for errors.
Signed-off-by: Alok Kumar [email protected]