Fast version of mine cargo ( no checkpoints ) #746
+76
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ziad hany <[email protected]>
keshav-space
requested changes
Oct 8, 2025
minecode_pipelines/miners/cargo.py
Outdated
| PACKAGE_BATCH_SIZE = 500 | ||
| COMMIT_BATCH_SIZE = 10 | ||
|
|
||
| BATCH_SIZE = 1000 |
There was a problem hiding this comment.
We don't need to declare this globally
minecode_pipelines/miners/cargo.py
Outdated
| COMMIT_BATCH_SIZE = 10 | ||
|
|
||
| BATCH_SIZE = 1000 | ||
| CARGO_CHECKPOINT_PATH = "cargo/checkpoints.json" |
There was a problem hiding this comment.
These checkpoint is no longer needed.
minecode_pipelines/miners/cargo.py
Outdated
| purl_files = [] | ||
| purls = [] | ||
|
|
||
| for file_path in base_path.rglob("*"): |
There was a problem hiding this comment.
Doing blanket rglob can be problematic, this will also iterate .git directory.
minecode_pipelines/miners/cargo.py
Outdated
| }: | ||
| continue | ||
|
|
||
| logger(f"Processing file: {file_path}") |
There was a problem hiding this comment.
This is not helpful, this will simply flood our log.
minecode_pipelines/miners/cargo.py
Outdated
| result = store_cargo_packages(packages, cloned_data_repo) | ||
| if result: | ||
| purl_file, base_purl = result | ||
| logger(f"Writing package URLs for package '{base_purl}' to {purl_file}") |
keshav-space
reviewed
Oct 8, 2025
minecode_pipelines/miners/cargo.py
Outdated
| purl_files = [] | ||
| purls = [] | ||
|
|
||
| for file_path in base_path.rglob("*"): |
There was a problem hiding this comment.
Also we should use LoopProgress when mining purls from resource for proper progress indication.
Signed-off-by: Keshav Priyadarshi <[email protected]>
Signed-off-by: Keshav Priyadarshi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.