Replaced ASSERT statements with if statements raising valueERROR #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shafi456
changed the title
pombredanne
reviewed
Feb 17, 2025
| @@ -58,8 +58,8 @@ def uncompress_file(location, decompressor): | |||
| # FIXME: do not create a sub-directory and instead strip the "compression" | |||
| # extension such gz, etc. or introspect the archive header to get the file | |||
| # name when present. | |||
| assert location | |||
| assert decompressor | |||
| if not location: raise ValueError("Invalid file location: Location cannot be none or empty.") | |||
There was a problem hiding this comment.
Good. Can you also add a test?
There was a problem hiding this comment.
Do you mean to add a unittest or pytest to verify that the new code behaves as expected?
pombredanne
requested changes
Feb 17, 2025
There was a problem hiding this comment.
Also: you are missing a signoff and you need to read https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue in extracode repo: src/extractcode/uncompress.py
aboutcode-org/aboutcode#175
Signed-off by Shafi456 ([email protected])