Skip to content

Conversation

anshul-dying
Copy link

This PR fixes the bug where the search field hint did not display the correct field for owner lookups. The hint now shows owner__name so users know to use the correct search syntax.

Signed-off-by:
Your Name [email protected]

@DennisClark DennisClark requested a review from tdruez July 28, 2025 18:51
@DennisClark
Copy link
Member

@anshul-dying thank you for your contribution, which needs to be reviewed by @tdruez and perhaps he can help with the commit message text.

@DennisClark
Copy link
Member

@anshul-dying I think that generally a PR title should state what the PR is doing (something like "Correct the search field prompt on Browse Licenses") rather than repeat the title of the original Issue. Again, I think that @tdruez needs to provide guidance on this.

@anshul-dying
Copy link
Author

@DennisClark
Yes, will surely keep that in mind for the next PR

@tdruez
Copy link
Contributor

tdruez commented Jul 30, 2025

@anshul-dying Thanks for the patch. Could you add a unit test to make sure the issue is fixed and will nnot be re-introduced in the fuiture?

@anshul-dying
Copy link
Author

@tdruez Can you please review this again I have added unit tests and they were successful

@tdruez
Copy link
Contributor

tdruez commented Aug 4, 2025

@tdruez Can you please review this again I have added unit tests and they were successful

@anshul-dying Are you sure that you have git pushed your changes?

@tdruez
Copy link
Contributor

tdruez commented Aug 12, 2025

@anshul-dying Thanks for your contribution. Merged in #379

@tdruez tdruez closed this Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants