Replace ASSERT statements with if statements #175 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pombredanne
requested changes
Feb 17, 2025
There was a problem hiding this comment.
Same as for your other PR: https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html
src/container_inspector/cli.py
Outdated
| @@ -41,7 +41,7 @@ def container_inspector_squash(image_path, extract_directory): | |||
|
|
|||
| def _container_inspector_squash(image_path, extract_directory): | |||
| images = get_images_from_dir_or_tarball(image_path) | |||
| assert len(images) == 1, 'Can only squash one image at a time' | |||
| if(len(images) == 1): raise ValueError("Can only squash one image at a time") | |||
There was a problem hiding this comment.
no one liner please, and check your code formatting.
There was a problem hiding this comment.
sorry I thought if extra lines were added it might clash or smth.
There was a problem hiding this comment.
Used the imperative mood in the message and changed the code(No one liners).
shafi456
changed the title
pombredanne
requested changes
Feb 21, 2025
| @@ -41,7 +41,8 @@ def container_inspector_squash(image_path, extract_directory): | |||
|
|
|||
| def _container_inspector_squash(image_path, extract_directory): | |||
| images = get_images_from_dir_or_tarball(image_path) | |||
| assert len(images) == 1, 'Can only squash one image at a time' | |||
| if(len(images) == 1): | |||
There was a problem hiding this comment.
Is the code formatted? Is this if statement correct?
You need to have a hard look, and if need be, also add a test that passes before making this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace ASSERT statements with if statements #175
Reported by: pombredanne aboutcode-org/aboutcode#175
Replace assert with explicit exception handling
Raise ValueError if inputs are invalid
Signed-off-by: Shafi456 [email protected]