Avoid nil invalid parameter when company-complete doesn't find any completion candidates. #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* counsel.el (counsel-company): Avoid nil invalid parameter when company-complete doesn't find any completion candidates (#2999). Copyright-paperwork-exempt: yes
|
Thanks! BTW, I think we've reached the limit of lines of code we can accept from you without a copyright assignment to the FSF on file. Do you have such an assignment already? If not, would you be willing to start the process? If you're unfamiliar with this, see |
|
Actually I did it last year, but I think I never got the pdf. I just sent
an email to them to see if I can sort it out. Will update you when I get a
response.
|
|
I received the document from FSF. Let me know the best way to send it to you, or whatever is needed. |
Great!
No need, thanks. Whoever merges your next contribution just needs to double check that your assignment is on file before the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.