* counsel.el: fix counsel failure with python-mode.el #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil-conto
requested changes
Sep 21, 2022
Problem: counsel-imenu fails in Python buffers with python-mode
from python-mode.el enabled.
Context: There is an Emacs builtin python-mode and some others, also
named python-mode. There is also a hard-coded call to
python-imenu-create-flat-index function in counsel.el. This
call is guarded by checking that the current major-mode is
python-mode. The issue is, both the built-in mode and that from
python-mode.el are named python-mode.
Solution: Since guarding the mode symbol is insufficient, let's check
if the function we want to use is defined.
* counsel.el (counsel--imenu-candidates): Avoid error with external
python-mode.el by checking python-imenu-create-flat-index is defined
before calling it. Check derived-mode-p instead of major-mode.
Fixes #2992
Copyright-paperwork-exempt: yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: counsel-imenu fails in python buffers with python-mode
from python-mode.el enabled.
Context: There is an emacs builtin python-mode and some others, also
named python-mode. There is also a hard-coded call to
python-imenu-create-flat-index function in counsel.el. This call
is guarded by checking that the current mode's symbol is
''python-mode. The issue is, both the builtin mode and the
python-mode.el modes use that symbol.
Solution: since guarding the mode symbol is insufficient, let's check
if the function we want to use is bound.
fixes #2992