Fix 'default' and 'copy' swiper-isearch actions #2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* swiper.el (swiper--isearch-candidate-pos): New convenience function. (swiper-isearch-action): Use it. Check this-command when ivy-exit fails to indicate that completion is "done" following default action 'M-o o'. (swiper-isearch-action-copy): New action function like swiper-action-copy, but for swiper-isearch (issue #2913). (swiper-isearch): Use it as the 'copy' action function.
basil-conto
force-pushed
the
blc/swiper-isearch
branch
from
279da9a to
9baa442
Compare
basil-conto
pushed a commit
to dustinpaluch/swiper
that referenced
this pull request
Mar 26, 2023
* swiper.el (swiper-isearch-action-insert): New function modeled after swiper-isearch-action-copy (abo-abo#2913, abo-abo#2914). (swiper-isearch): Override the default 'insert' action with it. Fixes abo-abo#2929. Copyright-paperwork-exempt: yes
basil-conto
added a commit
that referenced
this pull request
Mar 26, 2023
This takes into account swiper-goto-start-of-match and swiper-isearch-backward, under which point precedes and does not follow the candidate (#2913, #2914, #2929, #2963). * swiper.el (swiper--isearch-candidate-string): New helper function. (swiper-isearch-action-copy, swiper-isearch-action-insert): Use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swiper.el(swiper--isearch-candidate-pos): New convenience function.(
swiper-isearch-action): Use it. Check this-command whenivy-exitfails to indicate that completion is "done" following default actionM-o o.(
swiper-isearch-action-copy): New action function likeswiper-action-copy, but forswiper-isearch(swiper-isearch action doesn't go to the target #2913).(
swiper-isearch): Use it as the 'copy' action function.Cc: @allenryb