Fix ivy-restrict-to-matches for dynamic colls #2894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other parts of Ivy, specifically ivy--wnd-cands-to-str, use ivy-state-dynamic-collection to differentiate between programmed completion functions and Ivy's dynamic collections. By disabling ivy-state-dynamic-collection in ivy-restrict-to-matches, we lose this ability. This leads to errors when collections are mishandled. * ivy.el (ivy-restrict-to-matches): When disabling ivy-state-dynamic-collection, also make sure that minibuffer-completion-table no longer holds a dynamic collection. Re: #2875. Fixes #2893.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other parts of Ivy, specifically
ivy--wnd-cands-to-str, useivy-state-dynamic-collectionto differentiate between programmed completion functions and Ivy's dynamic collections. By disablingivy-state-dynamic-collectioninivy-restrict-to-matches, we lose this ability. This leads to errors when collections are mishandled.ivy.el(ivy-restrict-to-matches): When disablingivy-state-dynamic-collection, also make sure thatminibuffer-completion-tableno longer holds a dynamic collection.Cc: @ambihelical, @gexplorer.
Re: #2875.
Fixes #2893.