Groundwork for deletions and writes #42
Conversation
This is preparation for adding additional fields (e.g. tombstonedAt) per RTLM3a in [1]. [1] ably/specification#350
We'll use this when setting the upcoming tombstonedAt value for objects and map entries. This was all generated by Cursor; my only change was to add some locking into the mock class.
Per [1] at 488e932. Preparation for implementing this tombstoning spec. [1] ably/specification#350
Preparation for adding the `tombstone` method from [1]. (This approach is a _bit_ weird but it's what I could think of that's compatible with the existing LiveObjectMutableState approach.) [1] ably/specification#350
There isn't a spec PR for this yet, but it's needed in order to implement the write spec [1]. Asked about it in [2]. It's implemented in JS in [3]. Got Cursor to do this. [1] ably/specification#353 [2] https://github.com/ably/specification/pull/353/files#r2228017382 [3] ably/ably-js#2065
This will be needed for the write API (to extract object IDs from the entries that the user supplies when creating a LiveMap).
This will be needed for the write API (to incorporate the values that the user supplies when creating a LiveObject).
This will be needed for the write API (to extract object IDs from the entries that the user supplies when creating a LiveMap).
Generated by Cursor at my request. Useful for tests. Will refine this (e.g. to hide the usage of AsyncStream, and maybe tweak the name) in #4.
WalkthroughThis update introduces a new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PublicAPI
participant Logger
participant InternalObj
participant Clock
User->>PublicAPI: Create/Access LiveObject (Map/Counter)
PublicAPI->>Logger: Initialize logger
PublicAPI->>InternalObj: Create with logger, clock
InternalObj->>Clock: Access now (timestamp)
InternalObj->>InternalObj: Apply operation with timestamp
InternalObj->>PublicAPI: Return updated state
sequenceDiagram
participant ProtocolMsg
participant InternalObj
participant Clock
ProtocolMsg->>InternalObj: Receive ObjectMessage (w/ serialTimestamp)
InternalObj->>Clock: Use clock for time-based logic
InternalObj->>InternalObj: Store/propagate serialTimestamp
InternalObj->>InternalObj: Update state with timestamp awareness
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
lawrence-forooghian
force-pushed
the
groundwork-for-deletions-and-writes
branch
from
e5e82bf to
5fc3ed3
Compare
github-actions
bot
temporarily deployed
to
staging/pull/42/AblyLiveObjects
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
github-actions
bot
temporarily deployed
to
staging/pull/42/AblyLiveObjects
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
Sources/AblyLiveObjects/Internal/InternalObjectsMapEntry.swift (1)
1-1: Clarify comment abouttombstonedAtproperty.The comment mentions a
tombstonedAtproperty that doesn't exist in the current implementation. Consider updating the comment to accurately reflect the current structure or clarify that this refers to future changes.-/// The entries stored in a `LiveMap`'s data. Same as an `ObjectsMapEntry` but with an additional `tombstonedAt` property, per RTLM3a. (This property will be added in an upcoming commit.) +/// The entries stored in a `LiveMap`'s data. Same as an `ObjectsMapEntry` but with additional internal metadata for tombstone and timeserial tracking per RTLM3a.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (33)
Sources/AblyLiveObjects/Internal/CoreSDK.swift(3 hunks)Sources/AblyLiveObjects/Internal/DefaultInternalPlugin.swift(1 hunks)Sources/AblyLiveObjects/Internal/InternalDefaultLiveCounter.swift(10 hunks)Sources/AblyLiveObjects/Internal/InternalDefaultLiveMap.swift(26 hunks)Sources/AblyLiveObjects/Internal/InternalDefaultRealtimeObjects.swift(17 hunks)Sources/AblyLiveObjects/Internal/InternalLiveMapValue.swift(2 hunks)Sources/AblyLiveObjects/Internal/InternalLiveObject.swift(1 hunks)Sources/AblyLiveObjects/Internal/InternalObjectsMapEntry.swift(1 hunks)Sources/AblyLiveObjects/Internal/LiveObjectMutableState.swift(1 hunks)Sources/AblyLiveObjects/Internal/ObjectsPool.swift(8 hunks)Sources/AblyLiveObjects/Internal/SimpleClock.swift(1 hunks)Sources/AblyLiveObjects/Internal/SyncObjectsPoolEntry.swift(1 hunks)Sources/AblyLiveObjects/Protocol/ObjectMessage.swift(8 hunks)Sources/AblyLiveObjects/Protocol/WireObjectMessage.swift(10 hunks)Sources/AblyLiveObjects/Public/ARTRealtimeChannel+Objects.swift(1 hunks)Sources/AblyLiveObjects/Public/Public Proxy Objects/InternalLiveMapValue+ToPublic.swift(1 hunks)Sources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultLiveCounter.swift(1 hunks)Sources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultLiveMap.swift(4 hunks)Sources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultRealtimeObjects.swift(4 hunks)Sources/AblyLiveObjects/Public/Public Proxy Objects/PublicObjectsStore.swift(8 hunks)Sources/AblyLiveObjects/Public/PublicTypes.swift(4 hunks)Tests/AblyLiveObjectsTests/AblyLiveObjectsTests.swift(2 hunks)Tests/AblyLiveObjectsTests/Helpers/TestFactories.swift(3 hunks)Tests/AblyLiveObjectsTests/InternalDefaultLiveCounterTests.swift(16 hunks)Tests/AblyLiveObjectsTests/InternalDefaultLiveMapTests.swift(45 hunks)Tests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swift(1 hunks)Tests/AblyLiveObjectsTests/Mocks/MockCoreSDK.swift(1 hunks)Tests/AblyLiveObjectsTests/Mocks/MockSimpleClock.swift(1 hunks)Tests/AblyLiveObjectsTests/ObjectLifetimesTests.swift(1 hunks)Tests/AblyLiveObjectsTests/ObjectMessageTests.swift(0 hunks)Tests/AblyLiveObjectsTests/ObjectsPoolTests.swift(18 hunks)Tests/AblyLiveObjectsTests/WireObjectMessageTests.swift(0 hunks)ably-cocoa(1 hunks)
💤 Files with no reviewable changes (2)
- Tests/AblyLiveObjectsTests/WireObjectMessageTests.swift
- Tests/AblyLiveObjectsTests/ObjectMessageTests.swift
🧰 Additional context used
🧠 Learnings (15)
📚 Learning: applies to ablyliveobjects/**/!(*test|*tests).swift : when importing the ably module inside the ably...
Learnt from: CR
PR: ably/ably-cocoa-liveobjects-plugin#0
File: .cursor/rules/swift.mdc:0-0
Timestamp: 2025-07-29T08:07:47.875Z
Learning: Applies to AblyLiveObjects/**/!(*Test|*Tests).swift : When importing the Ably module inside the AblyLiveObjects library code (non-test code), use `import Ably`.
Applied to files:
Tests/AblyLiveObjectsTests/AblyLiveObjectsTests.swiftTests/AblyLiveObjectsTests/ObjectLifetimesTests.swiftSources/AblyLiveObjects/Internal/LiveObjectMutableState.swiftSources/AblyLiveObjects/Internal/InternalLiveMapValue.swiftTests/AblyLiveObjectsTests/Mocks/MockCoreSDK.swiftSources/AblyLiveObjects/Public/Public Proxy Objects/InternalLiveMapValue+ToPublic.swiftTests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swiftSources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultLiveMap.swiftTests/AblyLiveObjectsTests/Mocks/MockSimpleClock.swiftSources/AblyLiveObjects/Internal/InternalLiveObject.swiftSources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultRealtimeObjects.swiftSources/AblyLiveObjects/Public/PublicTypes.swiftTests/AblyLiveObjectsTests/ObjectsPoolTests.swiftSources/AblyLiveObjects/Internal/CoreSDK.swiftTests/AblyLiveObjectsTests/Helpers/TestFactories.swiftSources/AblyLiveObjects/Public/Public Proxy Objects/PublicObjectsStore.swiftSources/AblyLiveObjects/Internal/InternalDefaultRealtimeObjects.swiftTests/AblyLiveObjectsTests/InternalDefaultLiveCounterTests.swiftSources/AblyLiveObjects/Internal/InternalDefaultLiveCounter.swiftTests/AblyLiveObjectsTests/InternalDefaultLiveMapTests.swiftSources/AblyLiveObjects/Internal/InternalDefaultLiveMap.swift
📚 Learning: applies to ablyliveobjects/**/!(*test|*tests).swift : when importing the ablyplugin module inside th...
Learnt from: CR
PR: ably/ably-cocoa-liveobjects-plugin#0
File: .cursor/rules/swift.mdc:0-0
Timestamp: 2025-07-29T08:07:47.875Z
Learning: Applies to AblyLiveObjects/**/!(*Test|*Tests).swift : When importing the AblyPlugin module inside the AblyLiveObjects library code (non-test code), use `internal import AblyPlugin`.
Applied to files:
Tests/AblyLiveObjectsTests/AblyLiveObjectsTests.swiftSources/AblyLiveObjects/Public/ARTRealtimeChannel+Objects.swiftTests/AblyLiveObjectsTests/ObjectLifetimesTests.swiftSources/AblyLiveObjects/Internal/DefaultInternalPlugin.swiftSources/AblyLiveObjects/Internal/InternalObjectsMapEntry.swiftSources/AblyLiveObjects/Internal/InternalLiveMapValue.swiftTests/AblyLiveObjectsTests/Mocks/MockCoreSDK.swiftSources/AblyLiveObjects/Public/Public Proxy Objects/InternalLiveMapValue+ToPublic.swiftTests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swiftSources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultLiveMap.swiftTests/AblyLiveObjectsTests/Mocks/MockSimpleClock.swiftSources/AblyLiveObjects/Internal/InternalLiveObject.swiftSources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultLiveCounter.swiftSources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultRealtimeObjects.swiftSources/AblyLiveObjects/Public/PublicTypes.swiftTests/AblyLiveObjectsTests/ObjectsPoolTests.swiftSources/AblyLiveObjects/Internal/CoreSDK.swiftTests/AblyLiveObjectsTests/Helpers/TestFactories.swiftSources/AblyLiveObjects/Public/Public Proxy Objects/PublicObjectsStore.swiftSources/AblyLiveObjects/Internal/InternalDefaultRealtimeObjects.swiftSources/AblyLiveObjects/Internal/ObjectsPool.swiftTests/AblyLiveObjectsTests/InternalDefaultLiveCounterTests.swiftSources/AblyLiveObjects/Protocol/ObjectMessage.swiftSources/AblyLiveObjects/Internal/InternalDefaultLiveCounter.swiftTests/AblyLiveObjectsTests/InternalDefaultLiveMapTests.swiftSources/AblyLiveObjects/Internal/InternalDefaultLiveMap.swift
📚 Learning: applies to **/tests/**/*.swift : when you need to import the following modules in the tests, do so i...
Learnt from: CR
PR: ably/ably-cocoa-liveobjects-plugin#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-07-29T08:07:58.385Z
Learning: Applies to **/Tests/**/*.swift : When you need to import the following modules in the tests, do so in the following way: Ably: use `import Ably`; AblyLiveObjects: use `@testable import AblyLiveObjects`; AblyPlugin: use `import AblyPlugin`; do not do `internal import`.
Applied to files:
Tests/AblyLiveObjectsTests/AblyLiveObjectsTests.swiftTests/AblyLiveObjectsTests/ObjectLifetimesTests.swiftSources/AblyLiveObjects/Internal/InternalObjectsMapEntry.swiftSources/AblyLiveObjects/Internal/InternalLiveMapValue.swiftTests/AblyLiveObjectsTests/Mocks/MockCoreSDK.swiftSources/AblyLiveObjects/Public/Public Proxy Objects/InternalLiveMapValue+ToPublic.swiftTests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swiftSources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultLiveMap.swiftTests/AblyLiveObjectsTests/Mocks/MockSimpleClock.swiftSources/AblyLiveObjects/Internal/InternalLiveObject.swiftSources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultLiveCounter.swiftSources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultRealtimeObjects.swiftTests/AblyLiveObjectsTests/ObjectsPoolTests.swiftTests/AblyLiveObjectsTests/Helpers/TestFactories.swiftSources/AblyLiveObjects/Public/Public Proxy Objects/PublicObjectsStore.swiftSources/AblyLiveObjects/Internal/InternalDefaultRealtimeObjects.swiftSources/AblyLiveObjects/Internal/ObjectsPool.swiftTests/AblyLiveObjectsTests/InternalDefaultLiveCounterTests.swiftTests/AblyLiveObjectsTests/InternalDefaultLiveMapTests.swiftSources/AblyLiveObjects/Internal/InternalDefaultLiveMap.swift
📚 Learning: applies to **/tests/**/*.swift : when creating `testsonly_` property declarations, do not write gene...
Learnt from: CR
PR: ably/ably-cocoa-liveobjects-plugin#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-07-29T08:08:00.588Z
Learning: Applies to **/Tests/**/*.swift : When creating `testsOnly_` property declarations, do not write generic comments of the form 'Test-only access to the private createOperationIsMerged property'; the meaning of these properties is already well understood.
Applied to files:
Tests/AblyLiveObjectsTests/AblyLiveObjectsTests.swiftTests/AblyLiveObjectsTests/ObjectLifetimesTests.swiftTests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swiftTests/AblyLiveObjectsTests/ObjectsPoolTests.swiftTests/AblyLiveObjectsTests/Helpers/TestFactories.swiftTests/AblyLiveObjectsTests/InternalDefaultLiveCounterTests.swiftTests/AblyLiveObjectsTests/InternalDefaultLiveMapTests.swiftSources/AblyLiveObjects/Internal/InternalDefaultLiveMap.swift
📚 Learning: applies to **/tests/**/*.swift : only add labels to test cases or suites when the label is different...
Learnt from: CR
PR: ably/ably-cocoa-liveobjects-plugin#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-07-29T08:08:00.588Z
Learning: Applies to **/Tests/**/*.swift : Only add labels to test cases or suites when the label is different to the name of the suite `struct` or test method.
Applied to files:
Tests/AblyLiveObjectsTests/AblyLiveObjectsTests.swiftTests/AblyLiveObjectsTests/ObjectLifetimesTests.swiftTests/AblyLiveObjectsTests/InternalDefaultLiveCounterTests.swift
📚 Learning: applies to **/tests/**/*.swift : use the swift testing framework (`import testing`), not xctest....
Learnt from: CR
PR: ably/ably-cocoa-liveobjects-plugin#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-07-29T08:08:00.588Z
Learning: Applies to **/Tests/**/*.swift : Use the Swift Testing framework (`import Testing`), not XCTest.
Applied to files:
Tests/AblyLiveObjectsTests/AblyLiveObjectsTests.swift
📚 Learning: applies to **/tests/**/*.swift : do not use `fatalerror` in response to a test expectation failure. ...
Learnt from: CR
PR: ably/ably-cocoa-liveobjects-plugin#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-07-29T08:08:00.588Z
Learning: Applies to **/Tests/**/*.swift : Do not use `fatalError` in response to a test expectation failure. Favour the usage of Swift Testing's `#require` macro.
Applied to files:
Tests/AblyLiveObjectsTests/AblyLiveObjectsTests.swiftTests/AblyLiveObjectsTests/InternalDefaultLiveMapTests.swift
📚 Learning: the liveobjects functionality is referred to in the specification simply as 'objects'....
Learnt from: CR
PR: ably/ably-cocoa-liveobjects-plugin#0
File: .cursor/rules/specification.mdc:0-0
Timestamp: 2025-07-29T08:07:37.861Z
Learning: The LiveObjects functionality is referred to in the Specification simply as 'Objects'.
Applied to files:
Tests/AblyLiveObjectsTests/ObjectLifetimesTests.swiftSources/AblyLiveObjects/Internal/InternalObjectsMapEntry.swiftSources/AblyLiveObjects/Internal/InternalLiveObject.swiftSources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultRealtimeObjects.swiftSources/AblyLiveObjects/Internal/ObjectsPool.swiftSources/AblyLiveObjects/Internal/InternalDefaultLiveMap.swift
📚 Learning: applies to **/*.swift : when writing jsonvalue or wirevalue types, favour using the literal syntax e...
Learnt from: CR
PR: ably/ably-cocoa-liveobjects-plugin#0
File: .cursor/rules/swift.mdc:0-0
Timestamp: 2025-07-29T08:07:47.875Z
Learning: Applies to **/*.swift : When writing JSONValue or WireValue types, favour using the literal syntax enabled by their conformance to the `ExpressibleBy*Literal` protocols where possible.
Applied to files:
Sources/AblyLiveObjects/Internal/InternalLiveMapValue.swiftSources/AblyLiveObjects/Public/PublicTypes.swiftSources/AblyLiveObjects/Protocol/WireObjectMessage.swift
📚 Learning: applies to **/tests/**/*.swift : when you need to pass a logger to internal components in the tests,...
Learnt from: CR
PR: ably/ably-cocoa-liveobjects-plugin#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-07-29T08:07:58.385Z
Learning: Applies to **/Tests/**/*.swift : When you need to pass a logger to internal components in the tests, pass `TestLogger()`.
Applied to files:
Sources/AblyLiveObjects/Public/Public Proxy Objects/InternalLiveMapValue+ToPublic.swiftTests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swiftSources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultRealtimeObjects.swiftTests/AblyLiveObjectsTests/ObjectsPoolTests.swiftSources/AblyLiveObjects/Internal/InternalDefaultRealtimeObjects.swiftTests/AblyLiveObjectsTests/InternalDefaultLiveCounterTests.swiftTests/AblyLiveObjectsTests/InternalDefaultLiveMapTests.swift
📚 Learning: applies to **/tests/**/*.swift : when writing tests, make sure to add comments that explain when som...
Learnt from: CR
PR: ably/ably-cocoa-liveobjects-plugin#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-07-29T08:07:58.385Z
Learning: Applies to **/Tests/**/*.swift : When writing tests, make sure to add comments that explain when some piece of test data is not important for the scenario being tested.
Applied to files:
Tests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swiftTests/AblyLiveObjectsTests/ObjectsPoolTests.swiftTests/AblyLiveObjectsTests/InternalDefaultLiveCounterTests.swiftTests/AblyLiveObjectsTests/InternalDefaultLiveMapTests.swift
📚 Learning: applies to **/tests/**/*.swift : add comments that explain when some piece of test data is not impor...
Learnt from: CR
PR: ably/ably-cocoa-liveobjects-plugin#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-07-29T08:08:00.588Z
Learning: Applies to **/Tests/**/*.swift : Add comments that explain when some piece of test data is not important for the scenario being tested.
Applied to files:
Tests/AblyLiveObjectsTests/ObjectsPoolTests.swiftTests/AblyLiveObjectsTests/InternalDefaultLiveCounterTests.swiftTests/AblyLiveObjectsTests/InternalDefaultLiveMapTests.swift
📚 Learning: applies to **/tests/**/*.swift : follow the guidelines given under 'attributing tests to a spec poin...
Learnt from: CR
PR: ably/ably-cocoa-liveobjects-plugin#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-07-29T08:08:00.588Z
Learning: Applies to **/Tests/**/*.swift : Follow the guidelines given under 'Attributing tests to a spec point' in the file `CONTRIBUTING.md` in order to tag the unit tests with the relevant specification points. Make sure to follow the exact format of the comments as described in that file. Pay particular attention to the difference between the meaning of `@spec` and `@specPartial` and be sure not to write `@spec` multiple times for the same specification point.
Applied to files:
Tests/AblyLiveObjectsTests/ObjectsPoolTests.swiftTests/AblyLiveObjectsTests/InternalDefaultLiveMapTests.swift
📚 Learning: applies to **/tests/**/*.swift : when writing tests, follow the guidelines given under 'attributing ...
Learnt from: CR
PR: ably/ably-cocoa-liveobjects-plugin#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-07-29T08:07:58.385Z
Learning: Applies to **/Tests/**/*.swift : When writing tests, follow the guidelines given under 'Attributing tests to a spec point' in the file `CONTRIBUTING.md` in order to tag the unit tests with the relevant specification points. Make sure to follow the exact format of the comments as described in that file. Pay particular attention to the difference between the meaning of `@spec` and `@specPartial` and be sure not to write `@spec` multiple times for the same specification point.
Applied to files:
Tests/AblyLiveObjectsTests/ObjectsPoolTests.swiftTests/AblyLiveObjectsTests/InternalDefaultLiveMapTests.swift
📚 Learning: applies to **/tests/**/*.swift : when you need to unwrap an optional value in the tests, favour usin...
Learnt from: CR
PR: ably/ably-cocoa-liveobjects-plugin#0
File: .cursor/rules/testing.mdc:0-0
Timestamp: 2025-07-29T08:08:00.588Z
Learning: Applies to **/Tests/**/*.swift : When you need to unwrap an optional value in the tests, favour using `#require` instead of `guard let`.
Applied to files:
Tests/AblyLiveObjectsTests/InternalDefaultLiveMapTests.swift
🧬 Code Graph Analysis (6)
Tests/AblyLiveObjectsTests/AblyLiveObjectsTests.swift (1)
Sources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultRealtimeObjects.swift (1)
testsOnly_publish(78-80)
Sources/AblyLiveObjects/Internal/LiveObjectMutableState.swift (1)
Sources/AblyLiveObjects/Internal/CoreSDK.swift (1)
validateChannelState(56-68)
Sources/AblyLiveObjects/Internal/InternalLiveMapValue.swift (1)
Sources/AblyLiveObjects/Public/PublicTypes.swift (1)
lhs(139-156)
Tests/AblyLiveObjectsTests/Mocks/MockCoreSDK.swift (1)
Sources/AblyLiveObjects/Internal/CoreSDK.swift (1)
publish(32-39)
Sources/AblyLiveObjects/Public/PublicTypes.swift (4)
Sources/AblyLiveObjects/Internal/InternalDefaultLiveCounter.swift (1)
subscribe(100-114)Sources/AblyLiveObjects/Internal/InternalDefaultLiveMap.swift (1)
subscribe(179-193)Sources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultLiveCounter.swift (1)
subscribe(37-39)Sources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultLiveMap.swift (1)
subscribe(86-88)
Sources/AblyLiveObjects/Internal/InternalDefaultRealtimeObjects.swift (3)
Sources/AblyLiveObjects/Internal/CoreSDK.swift (2)
validateChannelState(56-68)publish(32-39)Sources/AblyLiveObjects/Internal/ObjectsPool.swift (1)
createZeroValueObject(171-199)Sources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultRealtimeObjects.swift (1)
testsOnly_publish(78-80)
🔇 Additional comments (95)
ably-cocoa (1)
1-1: Submodule bump looks correct – please ensure the workspace actually fetches the new commit.Only the SHA has changed, so there is no functional code to review here.
Before merging, rungit submodule update --init --recursive(or equivalent CI step) and open the Xcode workspace to confirm that the newably-cocoarevision (c72e1d7…) builds cleanly and that there are no API mismatches against the plugin code.Sources/AblyLiveObjects/Public/ARTRealtimeChannel+Objects.swift (1)
21-22: LGTM! Clean integration of logging support.The addition of the logger parameter follows the established pattern and aligns with the broader logging enhancement across the codebase.
Also applies to: 27-27
Tests/AblyLiveObjectsTests/ObjectLifetimesTests.swift (1)
165-165:proxiedis correctly exposed and matches the old test‐only accessorI confirmed that in
PublicDefaultLiveMap.swiftthere isinternal let proxied: InternalDefaultLiveMapwhich returns the same underlying instance you previously accessed via
testsOnly_proxied. Because tests use@testable import AblyLiveObjects,internalaccess is permitted, and assigningroot.proxiedto aweakvariable exercises the same deallocation path as before.Everything lines up—this API update is safe to approve.
Sources/AblyLiveObjects/Internal/DefaultInternalPlugin.swift (1)
41-41: DefaultSimpleClock VerifiedThe
DefaultSimpleClockclass is defined inSources/AblyLiveObjects/Internal/SimpleClock.swiftas aninternal final class DefaultSimpleClock: SimpleClock. The dependency injection ofDefaultSimpleClock()intoInternalDefaultRealtimeObjectson line 41 ofDefaultInternalPlugin.swiftis correct and aligns with the intended architecture.Sources/AblyLiveObjects/Internal/LiveObjectMutableState.swift (1)
91-91: LGTM! Good refactoring to centralize validation logic.The change from manual channel state validation to using
coreSDK.validateChannelState()improves maintainability by consolidating the validation logic into a reusable method while preserving the same error handling behavior.Tests/AblyLiveObjectsTests/AblyLiveObjectsTests.swift (1)
93-93: LGTM! Correct API rename in test code.The changes from
testsOnly_sendObjecttotestsOnly_publishcorrectly update the test calls to match the renamed method in the underlying implementation, maintaining the same functionality.Also applies to: 113-113
Tests/AblyLiveObjectsTests/Mocks/MockCoreSDK.swift (1)
14-16: LGTM! Method rename aligns with protocol changes.The method rename from
sendObjecttopublishcorrectly maintains consistency with the updatedCoreSDKprotocol while preserving the mock's intended behavior of callingprotocolRequirementNotImplemented().Sources/AblyLiveObjects/Internal/InternalLiveObject.swift (1)
1-8: Well-designed protocol for LiveObject polymorphism.The
InternalLiveObjectprotocol provides a clean abstraction for common LiveObject functionality with appropriateSendableconstraint on theUpdatetype. The protocol design enables polymorphic access to mutable state across different LiveObject implementations, supporting the broader architectural refactoring goals.Sources/AblyLiveObjects/Internal/InternalObjectsMapEntry.swift (2)
2-6: Well-structured internal map entry with proper spec annotations.The struct design appropriately extends
ObjectsMapEntrywith additional internal metadata. The property annotations (OME2a, OME2b, OME2c) correctly reference the specification.
8-14: Correct initialization from public ObjectsMapEntry.The initializer properly copies all properties from the public
ObjectsMapEntrytype, maintaining consistency between internal and public representations.Sources/AblyLiveObjects/Public/Public Proxy Objects/InternalLiveMapValue+ToPublic.swift (3)
1-1: Correct internal import following established conventions.The
internal import AblyPluginstatement follows the learned convention for importing AblyPlugin within non-test library code.
9-9: Logger property addition supports enhanced observability.Adding the
loggerproperty toPublicValueCreationArgsenables consistent logging propagation through the public proxy object creation flow.
12-12: Consistent logger propagation to creation arguments.The logger parameter is correctly passed to both
CounterCreationArgsandMapCreationArgs, maintaining consistency with the enhanced logging architecture.Also applies to: 16-16
Sources/AblyLiveObjects/Internal/SyncObjectsPoolEntry.swift (2)
1-7: Well-designed struct for time-aware synchronization.The
SyncObjectsPoolEntrystruct appropriately encapsulates both object state and timing metadata needed for the enhanced synchronization system. The documentation clearly explains its purpose in theOBJECT_SYNCsequence.
9-14: Excellent defensive programming with custom initializer.The custom initializer that explicitly requires both parameters is a smart approach to prevent accidental omission of the
objectMessageSerialTimestamp. This ensures proper timestamp tracking throughout the synchronization process.Sources/AblyLiveObjects/Internal/InternalLiveMapValue.swift (1)
58-74: LGTM! Consistent Equatable implementation.The equality logic correctly mirrors the public
LiveMapValueimplementation, using value equality for primitives and reference identity for live objects.Tests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swift (1)
13-13: LGTM! Proper mock clock injection for testing.Adding
MockSimpleClock()to the test helper correctly supports the new clock dependency, enabling deterministic time control in tests.Sources/AblyLiveObjects/Internal/SimpleClock.swift (1)
7-19: LGTM! Clean clock abstraction design.The
SimpleClockprotocol provides a focused interface for time operations with properSendableconformance for concurrent contexts. TheDefaultSimpleClockimplementation correctly uses the system clock. Clear documentation explains the testing benefits.Sources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultLiveMap.swift (3)
2-2: LGTM! Correct import style following coding guidelines.Using
internal import AblyPlugincorrectly follows the established coding guidelines for non-test library code.
8-8: LGTM! Consistent logger dependency integration.The changes properly integrate the logger dependency by making the proxied property internal, adding the logger property, and updating the initializer. This aligns with the broader logging enhancements across the codebase.
Also applies to: 14-14, 16-21
30-30: LGTM! Consistent logger propagation.All
creationArgsconsistently include the logger parameter, ensuring proper logging integration throughout the proxy object creation process.Also applies to: 50-50, 71-71
Tests/AblyLiveObjectsTests/InternalDefaultLiveCounterTests.swift (5)
13-13: LGTM! Consistent clock dependency injection in tests.All counter creation calls properly include
MockSimpleClock()to support the new clock dependency, enabling deterministic time control in tests.Also applies to: 31-31, 47-47, 63-63, 90-90, 103-103, 119-119, 139-139, 161-161, 185-185, 201-201, 225-225, 266-266, 290-290, 328-328, 364-364, 404-404
35-35: LGTM! Updated method signatures with timestamp parameter.All
replaceDatacalls correctly include the newobjectMessageSerialTimestamp: nilparameter, aligning with the updated method signatures that support timestamp-aware logic.Also applies to: 51-51, 70-70, 80-80, 95-95, 107-107, 125-125, 143-143, 165-165, 206-206, 229-229, 270-270, 297-297, 371-371
132-132: LGTM! Method name updated to reflect non-test-only usage.The method name change from
testsOnly_mergeInitialValuetomergeInitialValuecorrectly reflects that this method is no longer test-only and is used in production code.Also applies to: 148-148, 173-173, 189-189
303-303: LGTM! ObjectsPool creation with clock dependency.All
ObjectsPoolcreation calls properly include the clock dependency, maintaining consistency with the new constructor requirements.Also applies to: 335-335, 378-378, 411-411
310-310: LGTM! Operation application with timestamp parameter.All
applymethod calls correctly include the newobjectMessageSerialTimestamp: nilparameter, supporting the enhanced timestamp-aware operation handling.Also applies to: 342-342, 385-385, 416-416
Tests/AblyLiveObjectsTests/Mocks/MockSimpleClock.swift (1)
17-39: LGTM!The mock clock implementation correctly uses mutex locking for thread-safe access to the current time, and provides a clear API for testing time-dependent functionality.
Tests/AblyLiveObjectsTests/ObjectsPoolTests.swift (3)
12-15: LGTM!The consistent addition of
clock: MockSimpleClock()parameter across all test methods properly supports the new time-aware functionality. The tests maintain good structure with proper spec annotations.Also applies to: 25-26, 40-43, 57-59, 67-69, 88-91, 126-129, 158-159, 185-186, 211-212, 233-237, 260-264, 280-282, 289-293
33-33: Good API improvementThe change from
testsOnly_objectIDtoobjectIDmakes the API cleaner by promoting this property from test-only to regular API usage.Also applies to: 50-50, 175-175, 203-203, 357-357, 364-364
103-103: Consistent adaptation to new APIThe wrapping of object states in
SyncObjectsPoolEntrywithobjectMessageSerialTimestamp: nilis correctly applied throughout all test cases, properly adapting to the new time-aware synchronization API.Also applies to: 138-138, 166-166, 194-194, 221-221, 246-246, 264-264, 327-327
Sources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultLiveCounter.swift (1)
8-18: LGTM!The addition of the logger dependency and simplification of the
proxiedproperty declaration improve the code structure. The dependency injection pattern is properly implemented.Sources/AblyLiveObjects/Public/Public Proxy Objects/PublicDefaultRealtimeObjects.swift (2)
16-21: LGTM!The logger dependency injection is consistently implemented, and it's properly passed through to
PublicObjectsStorefor proxy lifecycle logging.Also applies to: 33-33
78-80: Method rename aligns with protocol changesThe rename from
testsOnly_sendObjecttotestsOnly_publishcorrectly reflects the corresponding change in theCoreSDKprotocol.Sources/AblyLiveObjects/Public/PublicTypes.swift (3)
86-157: Well-designed Equatable implementationThe custom equality implementation correctly distinguishes between value equality for primitives and reference identity for live objects. This is the appropriate semantic for mutable live objects.
289-289: LGTM!Adding
Equatableconformance toPrimitiveObjectValueenables value comparison and is consistent with theLiveMapValueimplementation.
399-420: Excellent async/await API additionThe
updates()method provides a modern Swift concurrency interface that:
- Properly wraps the callback-based subscription API
- Handles cleanup via
onTerminationto prevent memory leaks- Enables idiomatic Swift code with
for awaitloopsSources/AblyLiveObjects/Internal/CoreSDK.swift (2)
8-9: Method rename looks good!The rename from
sendObjecttopublishaligns better with Ably's terminology and the documentation clearly indicates it implements the internal#publishmethod of RTO15.Also applies to: 32-33
46-69: Well-structured channel state validation utility!The new
validateChannelStateextension method provides a clean, reusable way to validate channel states with detailed error construction. This centralization will help maintain consistency across the codebase.Tests/AblyLiveObjectsTests/Helpers/TestFactories.swift (2)
344-344: Parameter simplification looks correct.The change from
Data?toString?forinitialValueand removal ofinitialValueEncodingaligns with the protocol simplification mentioned in the summary.Also applies to: 354-354
405-418: Internal factory methods are well-documented.The new
internalMapEntryandinternalStringMapEntryfactory methods are properly documented to indicate they should be kept in sync with their public counterparts. This will help prevent divergence between the internal and public APIs.Also applies to: 437-454
Sources/AblyLiveObjects/Public/Public Proxy Objects/PublicObjectsStore.swift (2)
1-1: Import statement follows correct pattern.Using
internal import AblyPluginis correct for non-test code in the AblyLiveObjects library.
71-88: Excellent structured logging implementation!The addition of debug logging for proxy lifecycle events (creation, reuse, cleanup) provides valuable observability. The log messages include both proxy and proxied object identifiers, making debugging much easier.
Also applies to: 93-102
Sources/AblyLiveObjects/Protocol/WireObjectMessage.swift (2)
18-18: Timestamp support properly integrated.The addition of
serialTimestampto wire messages and map entries is consistently implemented with proper encoding/decoding logic that follows the Ably protocol date format (milliseconds since epoch).Also applies to: 32-32, 46-46, 102-102, 139-140, 439-439, 454-454, 469-470
161-274: Clean refactoring of WireObjectOperation.The split into
PartialWireObjectOperationandWireObjectOperationis well-designed, avoiding code duplication by delegating encoding/decoding logic. The change toString?forinitialValuesimplifies the protocol.Sources/AblyLiveObjects/Internal/ObjectsPool.swift (3)
37-37: Timestamp propagation properly implemented.The addition of
objectMessageSerialTimestampparameter through theapplyandreplaceDatamethods enables proper timestamp-aware handling of object updates. The documentation clearly explains the parameter's purpose.Also applies to: 46-46, 54-54, 82-84
123-123: Clock dependency injection follows best practices.The addition of
SimpleClockparameter throughout initialization and object creation methods enables proper time-aware operations and improves testability by allowing mock clocks in tests.Also applies to: 129-129, 137-137, 142-142, 169-171, 189-189, 191-191
203-203: SyncObjectsPoolEntry integration is well-structured.The change from
[ObjectState]to[SyncObjectsPoolEntry]properly encapsulates object state with its timestamp. The timestamp is correctly propagated toreplaceDatacalls, enabling time-aware synchronization.Also applies to: 206-206, 217-268
Tests/AblyLiveObjectsTests/InternalDefaultLiveMapTests.swift (9)
13-13: LGTM!Correct addition of
MockSimpleClock()as the clock parameter, consistent with the pattern used throughout the test file.
33-33: LGTM!Consistent addition of the clock parameter.
41-44: LGTM!Appropriate update to use the internal factory method
internalMapEntry, consistent with the new internal data structure.
46-46: LGTM!Consistent updates throughout these test methods:
- Clock parameter added to all
InternalDefaultLiveMapinitializations- Factory methods updated to use internal variants
- All changes follow the established pattern
Also applies to: 54-56, 66-68, 77-79, 88-90, 99-102
111-116: LGTM!Clock parameter correctly added to both
InternalDefaultLiveMapandInternalDefaultLiveCounterinitializations, demonstrating consistent implementation across different live object types.Also applies to: 130-132
156-162: LGTM!Correct addition of:
- Clock parameter to
ObjectsPoolinitializationobjectMessageSerialTimestamp: nilto thereplaceDatamethod callThese changes align with the new timestamp-aware API.
171-180: LGTM!All remaining changes follow the same consistent patterns:
MockSimpleClock()added to all object and pool initializationsobjectMessageSerialTimestamp: niladded to allreplaceDatacalls- Factory methods updated to use internal variants where applicable
The systematic nature of these changes demonstrates thorough refactoring across the entire test suite.
Also applies to: 187-187, 199-207, 220-237, 294-307, 342-351, 379-399, 440-447, 480-487, 552-554, 603-617, 652-657, 678-683, 718-718, 740-740, 803-810
830-830: Method rename handled correctlyThe promotion of
testsOnly_mergeInitialValuetomergeInitialValuehas been consistently applied throughout the test file. This aligns with the method's promotion from test-only to main API status.Also applies to: 848-848, 883-883, 922-922, 937-937, 956-956
1012-1021: LGTM!The
applymethod calls have been correctly updated with theobjectMessageSerialTimestamp: nilparameter, completing the systematic update of method signatures to support timestamp-aware operations.Also applies to: 1028-1034, 1063-1069, 1115-1121, 1166-1172, 1197-1203
Sources/AblyLiveObjects/Internal/InternalDefaultRealtimeObjects.swift (8)
13-13: LGTM!Addition of the
clockproperty follows the established pattern of dependency injection for time-aware operations.
48-48: LGTM!The type change to
[SyncObjectsPoolEntry]correctly reflects the need to pair each object state with its serial timestamp during synchronization.
74-81: LGTM!Clock dependency properly injected through the initializer and correctly propagated to
MutableStateandObjectsPoolinitialization.
95-96: Good refactoring!Using
coreSDK.validateChannelStatecentralizes the validation logic and improves code maintainability. The method correctly validates against DETACHED and FAILED states as required by RTO1b.
167-176: LGTM!Clock parameter correctly propagated through:
handleObjectProtocolMessagehandleObjectSyncProtocolMessagetestsOnly_createZeroValueLiveObjectThis ensures consistent time source availability throughout the object handling pipeline.
Also applies to: 184-194, 200-203
206-211: Method rename is consistentThe rename from
testsOnly_sendObjecttotestsOnly_publishcorrectly aligns with the CoreSDK API change. The method now callscoreSDK.publishinstead of the previoussendObjectmethod.
264-264: LGTM!The implementation correctly:
- Passes the clock parameter through the method
- Constructs
SyncObjectsPoolEntryobjects pairing state with timestamp- Handles both multi-message sync sequences (RTO5a) and single-message syncs (RTO5a5)
The mapping logic properly filters out messages without object data while preserving the timestamp information.
Also applies to: 272-272, 301-307, 318-324, 334-334
345-345: LGTM!Clock parameter consistently propagated through all remaining method calls:
applyObjectProtocolMessageObjectMessagehandleObjectProtocolMessageapplyoperationsThis completes the systematic addition of time-awareness throughout the internal realtime objects implementation.
Also applies to: 362-362, 382-382, 393-393, 410-410, 428-428
Sources/AblyLiveObjects/Protocol/ObjectMessage.swift (9)
17-17: LGTM!Addition of
serialTimestampproperty toInboundObjectMessageper OM2j specification.
31-32: LGTM!Addition of
serialTimestampproperty toOutboundObjectMessagemaintains consistency withInboundObjectMessage.
34-45: Good architectural designThe introduction of
PartialObjectOperationprovides a clean separation for encoding operations withoutobjectId. The change fromData?toString?forinitialValuesimplifies the encoding logic by removing format-dependent handling.
55-55: LGTM!Type change to
String?forinitialValueis consistent withPartialObjectOperation.
82-82: LGTM!Addition of
serialTimestamptoObjectsMapEntryper OME2d specification enables timestamp tracking at the entry level.
122-122: LGTM!Wire format conversions correctly handle the new
serialTimestampfield for both inbound and outbound messages.Also applies to: 142-142
147-211: Well-structured delegation patternThe implementation correctly:
- Delegates encoding/decoding to
PartialObjectOperationto avoid duplication- Preserves
objectIdseparately as it's not part of the partial operation- Maintains clean separation of concerns between full and partial operations
This design makes the code more maintainable and reduces the chance of inconsistencies.
213-254: LGTM!
PartialObjectOperationimplementation correctly:
- Handles all operation fields except
objectId- Sets
nonceandinitialValueto nil on inbound data per OOP3g/OOP3h- Simplifies
initialValueencoding by passing it directly asString?
416-416: LGTM!Wire conversion for
ObjectsMapEntrycorrectly includes the newserialTimestampfield.Sources/AblyLiveObjects/Internal/InternalDefaultLiveCounter.swift (11)
14-14: LGTM!Property rename from
liveObjecttoliveObjectMutableStateimproves clarity and is consistently applied throughout the accessor methods.Also applies to: 20-20
26-26: LGTM!Clock dependency properly injected through all constructors and initialization paths. The pattern is consistent with other internal live object implementations.
Also applies to: 35-36, 45-46, 50-50, 61-62, 68-68
72-78: Good additionThread-safe
objectIDaccessor provides necessary access to the object identifier while maintaining proper synchronization.
84-84: LGTM!Consistent use of
coreSDK.validateChannelStatefor channel state validation, matching the pattern in other internal classes.
104-104: LGTM!All references correctly updated to use
liveObjectMutableStateinstead of the oldliveObjectproperty name.Also applies to: 110-110, 118-118, 138-138
145-154: LGTM!Method signature properly updated to accept
objectMessageSerialTimestampparameter with clear documentation explaining its purpose for tombstoning.
157-162: LGTM!Method correctly promoted from
testsOnly_mergeInitialValuetomergeInitialValue, consistent with the same change inInternalDefaultLiveMap.
178-196: LGTM!The
applymethod signature correctly updated withobjectMessageSerialTimestampparameter and properly propagated to the mutable state.
201-201: Good architectural improvement
MutableStatenow conforms toInternalLiveObjectprotocol, providing a unified abstraction for internal live object state handling across different object types.
203-203: LGTM!All references to the mutable state property have been consistently updated throughout the
MutableStateimplementation.Also applies to: 217-220, 249-249, 264-264, 271-271, 281-281, 286-286, 298-298
209-215: LGTM!Method signatures in
MutableStatecorrectly updated withobjectMessageSerialTimestampparameter, maintaining consistency with the public interface.Also applies to: 259-259
Sources/AblyLiveObjects/Internal/InternalDefaultLiveMap.swift (11)
17-17: LGTM! Type change aligns with internal entry unification.The change from
ObjectsMapEntrytoInternalObjectsMapEntryis consistent with the PR's goal of unifying internal data entry types.
31-31: LGTM! Property rename improves clarity.The rename from
liveObjecttoliveObjectMutableStatebetter communicates the purpose of this property.Also applies to: 37-37
43-43: LGTM! Clock injection improves testability.Adding
SimpleClockas a dependency enables deterministic testing and time-aware operations throughout the LiveMap implementation.Also applies to: 53-53, 61-61, 71-71, 76-76, 89-89, 97-97
103-108: LGTM! Thread-safe objectID accessor.The new
objectIDproperty provides proper thread-safe access to the object identifier, replacing the previous test-only accessor.
136-136: LGTM! Centralized tombstone checking improves maintainability.The
isEntryTombstonedhelper method properly implements RTLM14 checks and centralizes the tombstone logic used insize()andentries().Also applies to: 150-150, 663-666
228-228: LGTM! Timestamp parameter enables time-aware operations.Adding
objectMessageSerialTimestampsupports proper tombstoning and synchronization, which aligns with the PR's groundwork for deletions and writes.Also applies to: 231-231, 236-236, 276-276, 284-284
366-366: LGTM! Proper conversion to internal entry type.The conversion from
ObjectsMapEntrytoInternalObjectsMapEntryusingmapValueswith the initializer is clean and correct.
239-239: LGTM! Consistent clock propagation throughout.The
clockparameter is properly threaded through all methods that perform time-aware operations, ensuring consistent time handling across the codebase.Also applies to: 253-253, 266-266, 288-288, 310-310, 375-375, 389-389, 411-411, 448-448, 467-467, 489-489, 519-519, 546-546, 628-628, 644-644
670-670: LGTM! Method signature updated for internal entry type.The
convertEntryToLiveMapValuemethod signature properly reflects the migration toInternalObjectsMapEntry.
114-114: Channel state validation confirmedThe
validateChannelStatemethod in Sources/AblyLiveObjects/Internal/CoreSDK.swift (lines 56–68) correctly:
- Checks the channel’s current state against the provided
invalidStates- Throws
LiveObjectsError.objectsOperationFailedInvalidChannelState(...).toARTErrorInfo()when in an invalid state (ARTErrorInfo code 90001, statusCode 400)This aligns with the RTLM5c, RTLM10c, and RTLM11c requirements. No further changes needed.
336-338: InternalLiveObject conformance verifiedThe
MutableStatestruct inInternalDefaultLiveMap.swiftcorrectly fulfills all requirements of theInternalLiveObjectprotocol:
- It provides the
liveObjectMutableStateproperty of typeLiveObjectMutableState<DefaultLiveMapUpdate>, which infers the associatedUpdatetype.- The protocol only mandates an associated
Update: Sendableand that property, both of which are satisfied.No changes needed.
Generated by Cursor at my request (although I largely replaced its code). Useful for tests.
I'm trying to debug an issue and this will be helpful. Code largely generated by Cursor at my instruction.
This is preparation for tombstoning an object per [1]; we'll need the ObjectMessage's serialTimestamp. [1] ably/specification#350
Preparation for making these methods perform tombstoning per [1] (not implemented yet). [1] ably/specification#350
The logic for this check is going to expand when we implement the tombstoning spec [1], so let's DRY it up. [1] ably/specification#350
The commit that we're currently using no longer exists due to rebases of feature branches (which have now been merged).
We need a type that represents (when considering [1] at cb11ba8) RTO13's "partial ObjectOperation"; namely an ObjectOperation without an objectId property. This is something that is easy to represent in TypeScript but a bit of a faff in Swift; we have to create a new type for it. Code largely generated by Cursor at my instruction. [1] ably/specification#353
Code largely generated by Cursor at my request.
Based on [1] at cb11ba8. Implementation deferred to #47. [1] ably/specification#353
lawrence-forooghian
force-pushed
the
groundwork-for-deletions-and-writes
branch
from
ec5e928 to
bbf8229
Compare
Note: This PR is based on top of #27; please review that one first.
Some refactors and other changes that I've pulled out of the upcoming PRs for implementing ably/specification#350 and ably/specification#353. See commit messages for more details.
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Tests
Chores