[AIT-287] Implement new rules for discarding buffered object operations #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
temporarily deployed
to
staging/pull/112/AblyLiveObjects
We added the UnitTests test plan — which is meant to run quickly by excluding long-running integration tests — in b38ce55, but I forgot to tag the tests as they were added.
lawrence-forooghian
force-pushed
the
AIT-287-new-rules-for-discarding-buffered-events
branch
from
11de235 to
5e0c796
Compare
github-actions
bot
temporarily deployed
to
staging/pull/112/AblyLiveObjects
lawrence-forooghian
force-pushed
the
AIT-287-new-rules-for-discarding-buffered-events
branch
from
5e0c796 to
45e17cd
Compare
github-actions
bot
temporarily deployed
to
staging/pull/112/AblyLiveObjects
Tests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swift
Outdated
Show resolved
Hide resolved
Tests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swift
Outdated
Show resolved
Hide resolved
Tests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swift
Outdated
Show resolved
Hide resolved
Tests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swift
Outdated
Show resolved
Hide resolved
Tests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swift
Outdated
Show resolved
Hide resolved
Tests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swift
Outdated
Show resolved
Hide resolved
Tests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swift
Outdated
Show resolved
Hide resolved
Tests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swift
Outdated
Show resolved
Hide resolved
Tests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swift
Outdated
Show resolved
Hide resolved
Tests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swift
Outdated
Show resolved
Hide resolved
Tests/AblyLiveObjectsTests/InternalDefaultRealtimeObjectsTests.swift
Outdated
Show resolved
Hide resolved
lawrence-forooghian
force-pushed
the
AIT-287-new-rules-for-discarding-buffered-events
branch
from
45e17cd to
18a9f76
Compare
github-actions
bot
temporarily deployed
to
staging/pull/112/AblyLiveObjects
lawrence-forooghian
force-pushed
the
AIT-287-new-rules-for-discarding-buffered-events
branch
2 times, most recently
from
a9c8eef to
83643ca
Compare
github-actions
bot
temporarily deployed
to
staging/pull/112/AblyLiveObjects
lawrence-forooghian
force-pushed
the
AIT-287-new-rules-for-discarding-buffered-events
branch
from
83643ca to
6125bf0
Compare
github-actions
bot
temporarily deployed
to
staging/pull/112/AblyLiveObjects
lawrence-forooghian
force-pushed
the
AIT-287-new-rules-for-discarding-buffered-events
branch
from
6125bf0 to
4942c24
Compare
github-actions
bot
temporarily deployed
to
staging/pull/112/AblyLiveObjects
That is, do it when we get a discontinuity, not when a new sync sequence starts, per spec changes in [1]. Integration tests ported from JS in [2] at 06b746a. All written by Claude. [1] ably/specification#416 [2] ably/ably-js#2150
lawrence-forooghian
force-pushed
the
AIT-287-new-rules-for-discarding-buffered-events
branch
from
4942c24 to
b8a86e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is currently a draft since ably/specification#416 and https://github.com/ably/ably-js/ pull/2150 are still in review.
That is, do it when we get a discontinuity, not when a new sync sequence starts, per spec changes in ably/specification#416.
Related PRs:
RESUMEDflag toonChannelAttachedably-cocoa-plugin-support#9RESUMEDflag to LiveObjectsonChannelAttachedably-cocoa#2185