Add extras in the message for channel push notifications #134
+36
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not support of push notifications with deviceId or clientId. Just have added
extras.pushsupport for channel pushes. Tried locally with./bin/run.js channels publish exampleChannel1 '{"data":"Test","extras":{"push":{"notification":{"title":"Hello","body":"World!"}}}}' --api-key "***"and it works.
Note
Low Risk
Small, additive change to
channels publishmessage construction that forwardsextrasto Ably; low blast radius but could affect message shape for callers relying onextrasbeing embedded indata.Overview
ably channels publishnow forwardsextrasfrom JSON input into the outgoing Ably message (and removes it fromdata), enablingextras.pushpayloads for push notifications.Documentation and command examples were updated to mention/show
extras.push, and a new unit test asserts thatextras.pushis included in the publish call.Written by Cursor Bugbot for commit 6a7494b. This will update automatically on new commits. Configure here.
Summary by CodeRabbit
New Features
Documentation
Tests