-
Notifications
You must be signed in to change notification settings - Fork 0
fix: update cursor set command examples to show correct usage. #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
splindsay-92
wants to merge
9
commits into
main
Choose a base branch
from
fix/correct-spaces-set-examples
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+104
−144
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
20bc06b
fix: update cursor set command examples to show correct usage.
splindsay-92 dedb81f
chore: add TERMINAL_SERVER_SIGNING_SECRET to E2E workflows
splindsay-92 58cf209
wip
splindsay-92 a68d650
wip
splindsay-92 47804ae
revert CI_BYPASS_SECRET change
splindsay-92 a53966b
use TERMINAL_SERVER_SIGNING_SECRET for CI
splindsay-92 5415628
wip
splindsay-92 cade3f0
wip
splindsay-92 d2971c2
wip
splindsay-92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rate-limit test bypass silently enabled by signing secret
Medium Severity
The rate-limit test group now has
TERMINAL_SERVER_SIGNING_SECRETset, and the bypass checks were changed fromCI_BYPASS_SECRETtoTERMINAL_SERVER_SIGNING_SECRET. Previously,CI_BYPASS_SECRETwas intentionally excluded from the rate-limit test group (as noted in the workflow comments) so rate limiting would remain active. Now, since the signing secret doubles as the bypass flag, the test rate limiter is effectively disabled (1000 connections, 0 pause) and the global setup initial delay is skipped, undermining the rate-limit test's purpose.Additional Locations (2)
test/e2e/web-cli/test-rate-limiter.ts#L23-L24test/e2e/web-cli/global-setup.ts#L100-L101