Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade upload-artifact version [skip cypress] #2332

Merged
merged 5 commits into from
Feb 4, 2025
Merged

upgrade upload-artifact version [skip cypress] #2332

merged 5 commits into from
Feb 4, 2025

Conversation

alexmance
Copy link
Collaborator

General Changes

  • upgrade update-artifact actions to version v4

@alexmance alexmance self-assigned this Feb 3, 2025
Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 11:40am
interface-ez7q ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 11:40am

Copy link

github-actions bot commented Feb 4, 2025

Copy link

github-actions bot commented Feb 4, 2025

Copy link

github-actions bot commented Feb 4, 2025

Copy link

github-actions bot commented Feb 4, 2025

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 865.89 KB (🟡 +7.85 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 52.53 KB (🟢 -142 B) 918.42 KB
/bridge 39.83 KB (🟡 +6 B) 905.72 KB
/governance 87.69 KB (🟡 +14 B) 953.58 KB
/governance/v3/proposal 131.03 KB (🟡 +7 B) 996.92 KB
/reserve-overview 26.21 KB (🟢 -143 B) 892.1 KB
/staking 29.55 KB (🟢 -8.76 KB) 895.44 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@alexmance alexmance requested review from foodaka and grothem February 4, 2025 11:49
Copy link

github-actions bot commented Feb 4, 2025

Copy link

github-actions bot commented Feb 4, 2025

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@grothem grothem changed the title upgrade upload-artifact version upgrade upload-artifact version [skip cypress] Feb 4, 2025
@grothem grothem merged commit cb0246d into main Feb 4, 2025
21 of 23 checks passed
@grothem grothem deleted the fix/pipeline branch February 4, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants