Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements OC-DECLARE (Object-Centric Declarative Constraints) discovery and conformance checking for the process_mining crate. It introduces algorithms for discovering behavioral constraints from object-centric event data, along with supporting data structures and utilities.
Changes:
- Adds OC-DECLARE constraint discovery algorithm with configurable options (noise threshold, O2O relationships, reduction modes)
- Introduces SlimLinkedOCEL - a memory-efficient linked OCEL implementation
- Refactors LinkedOCELAccess trait to use Borrow pattern and simplify type parameters
- Adds conformance checking implementation for validating discovered constraints
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| process_mining/src/discovery/object_centric/oc_declare/mod.rs | Core discovery algorithm implementation |
| process_mining/src/core/process_models/object_centric/oc_declare/mod.rs | Data structures for OC-DECLARE arcs, labels, and nodes |
| process_mining/src/core/event_data/object_centric/linked_ocel/slim_linked_ocel.rs | New efficient OCEL implementation |
| process_mining/src/core/event_data/object_centric/linked_ocel/mod.rs | Refactored LinkedOCELAccess trait |
| process_mining/src/conformance/object_centric/oc_declare.rs | Performance-focused constraint checking |
| process_mining/src/core/event_data/object_centric/linked_ocel/index_linked_ocel.rs | Updated to implement new trait signature |
| process_mining/src/core/event_data/object_centric/linked_ocel/id_linked_ocel.rs | Updated to implement new trait signature |
| process_mining/src/bindings/mod.rs | Added SlimLinkedOCEL to registry, improved parameter extraction |
| process_mining/examples/oc_declare.rs | Example demonstrating constraint discovery |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
process_mining/src/core/event_data/object_centric/linked_ocel/slim_linked_ocel.rs
Outdated
Show resolved
Hide resolved
process_mining/src/core/event_data/object_centric/linked_ocel/slim_linked_ocel.rs
Outdated
Show resolved
Hide resolved
process_mining/src/core/event_data/object_centric/linked_ocel/index_linked_ocel.rs
Outdated
Show resolved
Hide resolved
process_mining/src/core/event_data/object_centric/linked_ocel/slim_linked_ocel.rs
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
process_mining/src/core/event_data/object_centric/linked_ocel/slim_linked_ocel.rs
Outdated
Show resolved
Hide resolved
process_mining/src/core/event_data/object_centric/linked_ocel/slim_linked_ocel.rs
Outdated
Show resolved
Hide resolved
process_mining/src/core/event_data/object_centric/linked_ocel/slim_linked_ocel.rs
Outdated
Show resolved
Hide resolved
process_mining/src/core/event_data/object_centric/linked_ocel/mod.rs
Outdated
Show resolved
Hide resolved
process_mining/src/core/event_data/object_centric/utils/init_exit_events.rs
Outdated
Show resolved
Hide resolved
process_mining/src/core/event_data/object_centric/linked_ocel/slim_linked_ocel.rs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports OC-DECLARE (Object-Centric Declarative Constraints) to the
process_miningcrate.Pointers: