Skip to content

Issue 46: Switch netcoreapp2 to netstandard2 for libraries. … #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −4
Open

Issue 46: Switch netcoreapp2 to netstandard2 for libraries. … #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Original file line number Diff line number Diff line change
@@ -161,6 +161,7 @@ ClientBin/
*.pfx
*.publishsettings
node_modules/
*.nupkg

# RIA/Silverlight projects
Generated_Code/
2 changes: 1 addition & 1 deletion Algorithms/Algorithms.csproj
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
1 change: 0 additions & 1 deletion Algorithms/Numeric/SieveOfAtkin.cs
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using System.Collections.Generic;
using System.Reflection.Metadata.Ecma335;
using System.Threading.Tasks;

/***
2 changes: 1 addition & 1 deletion DataStructures/Common/PrimesList.cs
View file
Original file line number Diff line number Diff line change
@@ -225,7 +225,7 @@ private static string[] _readResource(string resourceName)
{
using (var stream = typeof(PrimesList).GetTypeInfo().Assembly.GetManifestResourceStream(resourceName))
using (var reader = new StreamReader(stream ?? throw new InvalidOperationException("Failed to read resource"), Encoding.UTF8))
return reader.ReadToEnd().Split("\n");
return reader.ReadToEnd().Split('\n');
}
catch (Exception ex)
{
2 changes: 1 addition & 1 deletion DataStructures/DataStructures.csproj
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
</PropertyGroup>

<ItemGroup>
3 changes: 3 additions & 0 deletions Nuget/c-sharp-algorithms.nuspec
View file
Original file line number Diff line number Diff line change
@@ -11,6 +11,9 @@
<projectUrl>https://github.com/aalhour/C-Sharp-Algorithms</projectUrl>
<icon>images\icon.png</icon>
<description>Plug-and-play class-library project of standard Data Structures and Algorithms in C#.</description>
<dependencies>
<group targetFramework=".NETStandard2.0" />
</dependencies>
</metadata>
<files>
<file src="..\Algorithms\bin\Release\**\*.*" target="lib" />