Skip to content

Conversation

@ishymko
Copy link
Member

@ishymko ishymko commented Feb 2, 2026

Description

Currently running uv run pytest in the freshly cloned repo fails due to optional dependencies not being installed by default for dev dependency group. This is also not documented in tests/README.md.

  1. Install all dependencies for dev group to provide better experience for contributors running tests locally after their changes. Tests which don't require any extra setup (like we have for tests against real DBs) should pass without additional actions.
  2. Remove extra dev dependencies duplicated in dev and other optional groups as we now reference all.
  3. Update readme with detailed instructions and mention script from test: add script to run DB integration tests locally #653.
  4. Rename the script from test: add script to run DB integration tests locally #653 so it doesn't conflict with "integration tests" we have for client-server integration.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the local development and testing experience. It achieves this by streamlining the project's development dependencies through consolidation into a single package and by introducing a dedicated, well-documented script for running database integration tests. These changes aim to make the testing workflow more efficient and user-friendly for developers.

Highlights

  • Dependency Management Streamlined: Several individual development dependencies (like PyJWT, fastapi, sse-starlette, and starlette) have been removed and consolidated into a single a2a-sdk[all] package in pyproject.toml and uv.lock.
  • Enhanced Database Integration Testing: A new script, scripts/run_db_tests.sh (renamed from scripts/run_integration_tests.sh), has been introduced to manage and execute database integration tests, including Docker-based setup for PostgreSQL and MySQL.
  • Improved Test Documentation: The tests/README.md file has been significantly updated to provide comprehensive instructions for running all tests, specific tests, and the new database integration tests, along with useful pytest flags.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/unit-tests.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ishymko ishymko changed the title tests: improve local dev experience test: improve local dev experience Feb 2, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the local development experience by updating test execution commands and enhancing the documentation in tests/README.md. The changes to pyproject.toml to consolidate development dependencies under a2a-sdk[all] and use a workspace source for uv are excellent. I've identified a couple of minor areas for improvement: an outdated script name in a user-facing message and a potentially destructive cleanup command in the documentation. These are small fixes that will further polish the developer experience.

@ishymko ishymko marked this pull request as ready for review February 2, 2026 12:37
@ishymko ishymko requested a review from a team as a code owner February 2, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants