-
Notifications
You must be signed in to change notification settings - Fork 344
test: improve local dev experience #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the local development and testing experience. It achieves this by streamlining the project's development dependencies through consolidation into a single package and by introducing a dedicated, well-documented script for running database integration tests. These changes aim to make the testing workflow more efficient and user-friendly for developers. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves the local development experience by updating test execution commands and enhancing the documentation in tests/README.md. The changes to pyproject.toml to consolidate development dependencies under a2a-sdk[all] and use a workspace source for uv are excellent. I've identified a couple of minor areas for improvement: an outdated script name in a user-facing message and a potentially destructive cleanup command in the documentation. These are small fixes that will further polish the developer experience.
fd0ffbf to
d261206
Compare
d261206 to
fe30cd9
Compare
Description
Currently running
uv run pytestin the freshly cloned repo fails due to optional dependencies not being installed by default fordevdependency group. This is also not documented intests/README.md.devgroup to provide better experience for contributors running tests locally after their changes. Tests which don't require any extra setup (like we have for tests against real DBs) should pass without additional actions.devand other optional groups as we now referenceall.