Skip to content

fix: return updated extended card in JsonRpcTransport.get_card() #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chaturvedakashamarendra wants to merge 1 commit into from
Closed

fix: return updated extended card in JsonRpcTransport.get_card() #606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/a2a/client/transports/jsonrpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ async def get_card(

self.agent_card = card
self._needs_extended_card = False
return card
return self.agent_card
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

This change improves consistency by returning the instance attribute. It's worth noting that the local card variable was updated on line 421, so the previous code returning card was also functionally correct. This change, however, is clearer about returning the instance's new state, which is good practice.

Copy link

@laylatrevithick90-rgb laylatrevithick90-rgb Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ed@ it

Copy link

@laylatrevithick90-rgb laylatrevithick90-rgb Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ed@ it


async def close(self) -> None:
"""Closes the httpx client."""
Expand Down
Loading