feat: Replace quarkus-rest(-client)-jackson with quarkus-rest(-client)

[kabir]

We no longer use Jackson

[gemini-code-assist]

Summary of Changes

Hello @kabir, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's dependencies by migrating away from explicit Jackson-specific Quarkus REST and REST Client extensions. The changes standardize the use of REST-related dependencies by replacing *-jackson artifacts with their generic quarkus-rest and quarkus-rest-client counterparts. This indicates a strategic shift in how JSON processing is integrated, aiming for a more unified or abstract approach within the application's architecture.

Highlights

• Dependency Update: The quarkus-resteasy-jackson dependency has been removed from boms/reference/src/it/reference-usage-test/pom.xml.
• Dependency Replacement: The quarkus-resteasy-jackson dependency has been replaced with quarkus-resteasy in examples/helloworld/server/pom.xml.
• Dependency Replacement: The quarkus-rest-client-jackson dependency has been replaced with quarkus-rest-client across multiple pom.xml files, including extras/push-notification-config-store-database-jpa/pom.xml, extras/task-store-database-jpa/pom.xml, reference/common/pom.xml, reference/jsonrpc/pom.xml, and reference/rest/pom.xml.
• Dependency Replacement: The quarkus-rest-jackson dependency has been replaced with quarkus-rest in tck/pom.xml.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to remove Jackson dependencies by replacing quarkus-rest-*-jackson artifacts. The changes are generally correct, but I've identified several areas where the choice of replacement dependencies could be improved for consistency across the project. Specifically, I've recommended standardizing on the RESTEasy Reactive stack (quarkus-rest for servers, quarkus-rest-client-reactive for clients) where RESTEasy Classic is currently being used, as this aligns better with the project's use of quarkus-reactive-routes. I also found one change that may break an integration test by removing a necessary dependency entirely, and I've suggested a fix.

I am having trouble creating individual review comments. Click here to see my feedback.

boms/reference/src/it/reference-usage-test/pom.xml (104-107)

The quarkus-resteasy-jackson dependency is removed, but this integration test module likely requires a REST implementation to run, as it depends on a2a-java-sdk-reference-rest. Simply removing this dependency may break the test. Considering other modules use the reactive stack, you should replace this with the quarkus-rest dependency.

        <dependency>
            <groupId>io.quarkus</groupId>
            <artifactId>quarkus-rest</artifactId>
        </dependency>

examples/helloworld/server/pom.xml (29)

For consistency with other modules that use the reactive stack (e.g., a2a-java-sdk-reference-jsonrpc which uses quarkus-reactive-routes), it would be better to use quarkus-rest (RESTEasy Reactive) instead of quarkus-resteasy (RESTEasy Classic). This will help maintain a uniform architecture across the project.

            <artifactId>quarkus-rest</artifactId>

extras/push-notification-config-store-database-jpa/pom.xml (58)

The tests in this module use a reactive server stack, as indicated by the quarkus-reactive-routes test dependency. For consistency and to better align with the reactive architecture, consider using the reactive REST client (quarkus-rest-client-reactive) instead of the classic one (quarkus-rest-client).

            <artifactId>quarkus-rest-client-reactive</artifactId>

extras/task-store-database-jpa/pom.xml (62)

The tests in this module use a reactive server stack, as indicated by the quarkus-reactive-routes test dependency. For consistency and to better align with the reactive architecture, consider using the reactive REST client (quarkus-rest-client-reactive) instead of the classic one (quarkus-rest-client).

            <artifactId>quarkus-rest-client-reactive</artifactId>

reference/common/pom.xml (63)

This module uses a reactive stack, as indicated by the quarkus-reactive-routes dependency. To maintain consistency in your test setup, consider using the reactive REST client (quarkus-rest-client-reactive) instead of the classic one (quarkus-rest-client).

            <artifactId>quarkus-rest-client-reactive</artifactId>

reference/jsonrpc/pom.xml (72)

This module uses a reactive stack, as indicated by the quarkus-reactive-routes dependency. To maintain consistency in your test setup, consider using the reactive REST client (quarkus-rest-client-reactive) instead of the classic one (quarkus-rest-client).

            <artifactId>quarkus-rest-client-reactive</artifactId>

reference/rest/pom.xml (82)

This module uses a reactive stack, as indicated by the quarkus-reactive-routes dependency. To maintain consistency in your test setup, consider using the reactive REST client (quarkus-rest-client-reactive) instead of the classic one (quarkus-rest-client).

            <artifactId>quarkus-rest-client-reactive</artifactId>