fix: Update container state for ItemRequirement on same tick #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might fix an issue where an inventory change occurs on the same tick as the check occurs. My theory is that the item added event occurs after the inventory check for an ItemRequirement on the same tick.
pajlada
approved these changes
Jan 26, 2025
PsycloneTM
pushed a commit
to PsycloneTM/quest-helper
that referenced
this pull request
Feb 3, 2025
…z#1957) This might fix an issue where an inventory change occurs on the same tick as the check occurs. My theory is that the item added event occurs after the inventory check for an ItemRequirement on the same tick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fix an issue where an inventory change occurs on the same tick as the check occurs.
My theory is that the item added event occurs after the inventory check for an ItemRequirement on the same tick.
This has been observed to occur for receiving items in Throne of Miscellania, and for At First Light. Ideally we can test those.