ch32 USBHD/USBHS driver implementation by Copper280z · Pull Request #893 · ZigEmbeddedGroup/microzig

Copper280z · 2026-01-31T20:28:31Z

This adds a new driver for the ch32 USBHD/USBHS peripheral, USB_OTG_FS peripheral, and examples for the ch32v307, and ch32v203 boards.

… once per packet

…terface

…pt endpoints

github-actions · 2026-01-31T20:28:57Z

Lint Results

Found 11 issues on changed lines in 4 files:

examples/wch/ch32v/src/usb_cdc.zig: 1 issue
port/wch/ch32v/src/hals/clocks.zig: 1 issue
port/wch/ch32v/src/hals/usbfs.zig: 5 issues
port/wch/ch32v/src/hals/usbhs.zig: 4 issues

…32v203 board.

…ng to board definitions, add max packet size to usb device hal.

Grazfather · 2026-02-07T21:52:22Z

+    _reserved1: u2 = 0,
+});
+
+fn baseAddr() usize {


this one actually makes sense

Grazfather

Reviewed everything except for the HALs themselves (since this is a draft). Will get to those when you think they're ready.

Grazfather · 2026-02-10T01:18:25Z

+            // pins.tog.put(0);
+            usb_dev.poll(false, &usb_controller);
+            // pins.tog.put(1);


gets rid of toggle pins completely or uncomment these please

The previous `init() Self` returned a copy of the struct, but set up DMA in the same function, causing DMA registers to be programmed with addresses pointing into a stack temporary.

Rewrite hw_init to follow WCH SDK init sequence with raw register writes, fixing endpoint mode configuration (disable EP4 which shares DMA with EP0, only enable EP1-3 needed for CDC-ACM). Fix poll loop: mask out SOF in the ignore filter to prevent spinning, use single-pass with early return, and add EP0 OUT re-arm after IN completion to correctly handle SETUP toggle sequencing.

USBFS fixes + merge upstream

github-actions · 2026-07-01T12:59:31Z

+    _ = microzig.export_startup();
+}
+
+const USBController = usb.DeviceController(.{


Suggestion: Rename USBController to USB_Controller, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.

github-actions · 2026-07-01T12:59:31Z

+///
+/// Note: The SVD names bit31 as `USBFSSRC`, but the reference manual
+/// describes it as `USBHSSRC` ("USBHS 48MHz clock source selection").
+pub const UsbHsClockConfig = struct {


Suggestion: Rename UsbHsClockConfig to USB_HsClockConfig, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.

github-actions · 2026-07-01T12:59:31Z

+
+const Regs = peripherals.USB_OTG_FS;
+
+const EpState = struct {


Suggestion: Rename EpState to EP_State, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.

github-actions · 2026-07-01T12:59:31Z

+}
+
+// We use offset-based access for per-EP regs to keep helpers compact.
+const RegU32 = microzig.mmio.Mmio(packed struct(u32) { v: u32 = 0 });


Suggestion: Rename RegU32 to Reg_U32, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.

github-actions · 2026-07-01T12:59:31Z

+
+// We use offset-based access for per-EP regs to keep helpers compact.
+const RegU32 = microzig.mmio.Mmio(packed struct(u32) { v: u32 = 0 });
+const RegU16 = microzig.mmio.Mmio(packed struct(u16) { v: u16 = 0 });


Suggestion: Rename RegU16 to Reg_U16, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.

github-actions · 2026-07-01T12:59:31Z

+    padding: u4 = 0,
+});
+
+fn baseAddr() usize {


Please change to base_addr, in MicroZig we use snake case for function names.

github-actions · 2026-07-01T12:59:31Z

+
+const Regs = peripherals.USBHS;
+
+const EpState = struct {


Suggestion: Rename EpState to EP_State, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.

github-actions · 2026-07-01T12:59:31Z

+}
+
+// We use offset-based access for per-EP regs to keep helpers compact.
+const RegU32 = microzig.mmio.Mmio(packed struct(u32) { v: u32 = 0 });


Suggestion: Rename RegU32 to Reg_U32, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.

github-actions · 2026-07-01T12:59:31Z

+
+// We use offset-based access for per-EP regs to keep helpers compact.
+const RegU32 = microzig.mmio.Mmio(packed struct(u32) { v: u32 = 0 });
+const RegU16 = microzig.mmio.Mmio(packed struct(u16) { v: u16 = 0 });


Suggestion: Rename RegU16 to Reg_U16, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.

github-actions · 2026-07-01T12:59:31Z

+// We use offset-based access for per-EP regs to keep helpers compact.
+const RegU32 = microzig.mmio.Mmio(packed struct(u32) { v: u32 = 0 });
+const RegU16 = microzig.mmio.Mmio(packed struct(u16) { v: u16 = 0 });
+const RegU8 = microzig.mmio.Mmio(packed struct(u8) { v: u8 = 0 });


Suggestion: Rename RegU8 to Reg_U8, it should be more in line with our style guidelines. This automation is not perfect so take it with a grain of salt.

piotrfila and others added 30 commits January 10, 2026 14:54

neccessary -> necessary and fix linter bot issue

d272589

scan unhandled buffer linearly

3e3b6de

redo endpoint handling

b587b46

separate getting usb rx data and requesting more

a653711

make CdcClassDriver rx interrupt-safe

9504866

add usb packet length type

52ea727

make CdcClass driver tx interrupt-safe

b655989

allow partial usb tx and require calling ep_writev and ep_listen only…

503c998

… once per packet

documentation and configurable handler names

93ce596

first draft of an example driver that explains the comptime driver in…

f210076

…terface

more error checking around interfaces and string descriptors

942aa42

endpoint_open -> ep_open for consistency

340d9c3

style fixes

9eabcab

appease linter bot

870f0d6

add u32 little endian wrapper

2a79c78

respect endianness in setup packet and shortcuts for bulk and interru…

f553d34

…pt endpoints

start at ch32v usb

27edab3

cleanum usb examples

2ed6b4d

change the example usb driver to a simple echo

cd4e348

assign endpoints and interfaces (more) automatically

0959d37

better handling of device class, subclass and protocol

36f02ea

separate usb device and controller

b7bed05

more convenient descriptor creation

93cbc87

handle bus resets correctly

55921cc

fix startup

f373714

more examples cleanup

bbe968f

add BOS descriptor

baee980

simplify setup packet handling

ae7d203

add usb device logging

a6e8c89

better use scoped logging

66f0116

Copper280z added 15 commits January 31, 2026 12:00

Merge remote-tracking branch 'upstream/main' into ch32_usb

dc8ec01

update for latest usb core changes

ad686c3

remove unfinished usbd driver

fce6646

revert to upstream with minimal updates for usbhs

8a0e752

revert changes to uart_log

57f498f

remove old example driver

8b9704c

cleanup

0049e03

cleanup usbhs clock setup

01624dc

more cleanup

19cc7f3

revert board clock setup to one that works on current upstream.

493c041

revert most of clocks.zig to upstream.

02ce566

mirror rp2xxx better

349fb6a

revert usart changes, cleanup example to match rp2xxx better

e0cef46

adjust comment

0717b51

get rid of regs function, change a log call

b9892ab

Copper280z added 5 commits February 2, 2026 22:43

usbfs works

0a2bde0

Add usbfs clock setup function, add support for v203 chips and nanoch…

e322393

…32v203 board.

Add more example build defs, clean up dev noise, add usb product stri…

026395f

…ng to board definitions, add max packet size to usb device hal.

remove zigscient rootid tag

a4927cc

clear IRQ flags after work is done to ensure clean NAK/ACK transition.

0480805

Grazfather reviewed Feb 7, 2026

View reviewed changes

Grazfather reviewed Feb 10, 2026

View reviewed changes

Grazfather and others added 6 commits May 30, 2026 10:39

Address comments: HSE in board file

cf90964

Cleanup cdc example

be83d63

Merge remote-tracking branch 'origin/main' into ch32_usb

4160fc9

ch32v: usb: use pointer receiver for init to fix DMA address corruption

dd03f96

The previous `init() Self` returned a copy of the struct, but set up DMA in the same function, causing DMA registers to be programmed with addresses pointing into a stack temporary.

Merge pull request #1 from ZigEmbeddedGroup/ch32_usb

2835214

USBFS fixes + merge upstream

github-actions Bot reviewed Jul 1, 2026

View reviewed changes


		const Regs = peripherals.USB_OTG_FS;

		const EpState = struct {

Uh oh!

Conversation

Copper280z commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lint Results

Uh oh!

Grazfather Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Grazfather left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Grazfather Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copper280z commented Jan 31, 2026 •

edited

Loading

github-actions Bot commented Jan 31, 2026 •

edited

Loading