Enable 'unwind_tables' for all platforms (for #370) #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ARM-based embedded firmware this requires explicit declaration of `ARM.extab` sections in linker.d, otherwise the exception tables can incorrectly end up in RAM. (See ziglang/zig#22685.)
marnix
changed the title
mattnite
approved these changes
Feb 2, 2025
|
Hello, this commit breaks the build for RISC-V, resulting in a 400MB firmware file for the CH32V003. The only workaround is to override with: Could you please fix this issue or add this override to the RISC-V example file so that others don’t have to deal with this problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ARM-based embedded firmware this requires
explicit declaration of
ARM.extabsections in linker.d, otherwise the exception tables can incorrectly end up in RAM. (See ziglang/zig#22685.)(The
.unwind_tables = trueline must be removed for Zig 0.14, which already has this enabled for basically all platforms.)Implements part of #370 already on Zig 0.13.0.