Interrupt refactor #369
Draft
Interrupt refactor #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
reviewed
Mar 3, 2025
| const uart = rp2xxx.uart.instance.num(0); | ||
| const baud_rate = 115200; | ||
| const uart_tx_pin = rp2xxx.gpio.num(12); | ||
| const uart_rx_pin = rp2xxx.gpio.num(13); |
There was a problem hiding this comment.
We don't see this since we are just using the uart for logging
| pub fn main() !void { | ||
| // init uart logging | ||
| inline for (&.{ uart_tx_pin, uart_rx_pin }) |pin| { | ||
| pin.set_function(.uart_first); |
There was a problem hiding this comment.
Isn't this enum RP2350 only?
|
|
||
| pub fn disable(comptime interrupt: anytype) void { | ||
| const interrupt_name = @tagName(interrupt); | ||
| if (@hasField(Interrupt, interrupt_name)) { |
There was a problem hiding this comment.
could probably abstract these checks out to some sort of 'interrupt is valid' comptime function to reduce duplicated logic.
| Naked: *const fn () callconv(.Naked) void, | ||
| // Interrupt is not supported on arm | ||
| }; | ||
| // TODO: remove this once the vector table uses it's own implementation |
| // TODO: maybe this should be relocated somewhere else | ||
| pub fn CSR(addr: u24, T: type) type { | ||
| const size = @bitSizeOf(T); | ||
| if (size != 32) |
There was a problem hiding this comment.
Why do we have this? Are there cases where it might be e.g. i32?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#355