Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usb_cdc on rp2350 #367

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Conversation

patryk4815
Copy link
Contributor

No description provided.

@mattnite mattnite requested review from haydenridd and ikskuh January 27, 2025 17:37
@haydenridd
Copy link
Collaborator

Good work! There's a question about whether rom.zig should really even be used on the RP2350 given they did away with rom functions for performance purposes. It makes sense though to allow some of those aliases to still "work" on the RP2350 for easier compatibility with the old HAL.

@patryk4815
Copy link
Contributor Author

patryk4815 commented Jan 28, 2025

[..] given they did away with rom functions for performance purposes.

Yes, they removed some of them.
image

There's a question about whether rom.zig should really even be used on the RP2350 [..]. It makes sense though to allow some of those aliases to still "work" on the RP2350 for easier compatibility with the old HAL.

I have no idea, people with more knowledge must decide, some functions from rom.zig maybe be still useful on RP2350
image

Copy link
Collaborator

@haydenridd haydenridd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good work! A future refactor of rom.zig is probably in order eventually, but this is to get USB working so let's merge!

@mattnite mattnite merged commit 68b5ad1 into ZigEmbeddedGroup:main Jan 28, 2025
30 checks passed
@mattnite
Copy link
Contributor

Thank you @patryk4815 for the great contribution and @haydenridd for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants