-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract USB device implementation #124
Conversation
🤌 |
In general I would prefer removing |
You're right, |
Just write everything down you dislike, I'll take care of it |
The only other change I'd like to see is to ensure that the unit tests run when you execute |
…urns a []const u8 instead of a []const u16
@r4gus is this ready to merge? |
@mattnite yes. Sending multiple packets between Host and Client seems to Work fine (with the rp2040). Adding Support for other Chips will probably reveal some shortcomings. |
Awesome |
I've extracted the platform independent code from the rp2040 device impl (see ZigEmbeddedGroup/raspberrypi-rp2040#40).
One can create a concrete implementation by calling
Usb(F)
, whereF
is a struct that contains a set of functions to handle the low level details (register access etc.).Check out the usb examples in the rp2040 repo!
@MasterQ32 @mattnite