Skip to content

Conversation

jonny-no1
Copy link

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foaly-nr1

The indentation is totally messed up.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been 2 years since I posted this, I am not sure if the PR is still relevant.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we haven't needed it up to this point, it's probably best to close it anyway. Any modules using ZfcBase have implemented this themselves already.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I retract my prior statement...it would be nice to have this, but implemented like this:

/**
 * @return ResultSetInterface
*/
public function findAll()
{
    return $this->select($this->getSelect());
}

Together with #64, this would remove the necessity for ZfcUserAdmin\Mapper\ZendDbMapper::findAll

@adamlundrigan
Copy link
Contributor

@Danielss89 this can be closed

@Danielss89 Danielss89 closed this Jan 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants