Skip to content

Commit

Permalink
Fix runtime error on shr INT_MAX
Browse files Browse the repository at this point in the history
  • Loading branch information
KrystalDelusion committed Feb 14, 2025
1 parent db5b76e commit 4c72896
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions passes/opt/opt_expr.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1315,6 +1315,10 @@ void replace_const_cells(RTLIL::Design *design, RTLIL::Module *module, bool cons
RTLIL::SigSpec sig_a = assign_map(cell->getPort(ID::A));
RTLIL::SigSpec sig_y(cell->type == ID($shiftx) ? RTLIL::State::Sx : RTLIL::State::S0, cell->getParam(ID::Y_WIDTH).as_int());

// Limit indexing to the size of a, which is behaviourally identical (result is all 0)
// and avoids integer overflow of i + shift_bits when e.g. ID::B == INT_MAX
shift_bits = min(shift_bits, GetSize(sig_a));

if (cell->type != ID($shiftx) && GetSize(sig_a) < GetSize(sig_y))
sig_a.extend_u0(GetSize(sig_y), cell->getParam(ID::A_SIGNED).as_bool());

Expand Down

0 comments on commit 4c72896

Please sign in to comment.