Fix breaking changes in backend #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shauneccles
commented
Dec 30, 2023
|
From Discord: Bug 1: Saving a new User Preset doesn't seem to be putting it in the preset store that /Scenes is using - the user preset doesn't show up until you refresh the page and get the config (and thus new preset) again. Bug 2: The preset category is hardcoded in the call to activate the preset, rather than being dynamic. I've fixed the breaking updates (I think) but I don't know enough to fix the other stuff Thought: The presets in /Scenes are using preset_id, but they could be using preset_id[name] to display the pretty name instead since we store/have the presets name? |
|
Frontend now resides in main ledfx repo - redundant PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the breaking changes potentially introduced in LedFx/LedFx#568
I need your help though, it doesn't actually fix the bug that I went looking for 🤣
I'll @ you inline, your magic is required.